From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759160AbbKSSUn (ORCPT ); Thu, 19 Nov 2015 13:20:43 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34153 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751736AbbKSSUl (ORCPT ); Thu, 19 Nov 2015 13:20:41 -0500 Date: Thu, 19 Nov 2015 10:20:38 -0800 From: Dmitry Torokhov To: Irina Tirdea Cc: Bastien Nocera , Aleksei Mamlin , Karsten Merker , linux-input@vger.kernel.org, Mark Rutland , Rob Herring , Octavian Purdila , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v11 3/8] Input: goodix - write configuration data to device Message-ID: <20151119182038.GA24773@dtor-ws> References: <1447936001-21420-1-git-send-email-irina.tirdea@intel.com> <1447936001-21420-4-git-send-email-irina.tirdea@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447936001-21420-4-git-send-email-irina.tirdea@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 19, 2015 at 02:26:36PM +0200, Irina Tirdea wrote: > + if (ts->gpiod_int && ts->gpiod_rst) { > + /* update device config */ > + ts->cfg_name = kasprintf(GFP_KERNEL, "goodix_%d_cfg.bin", > + ts->id); devm_kasprintf maybe (don't resubmit)? Thanks. -- Dmitry