All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: netdev@vger.kernel.org, will.deacon@arm.com,
	ard.biesheuvel@linaro.org, grundler@parisc-linux.org
Subject: Re: [PATCH] net: tulip: turn compile-time warning into dev_warn()
Date: Fri, 20 Nov 2015 11:03:14 -0500 (EST)	[thread overview]
Message-ID: <20151120.110314.213434169745300737.davem@davemloft.net> (raw)
In-Reply-To: <9720627.53btSdPcQU@wuerfel>

From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 19 Nov 2015 11:42:26 +0100

> The tulip driver causes annoying build-time warnings for allmodconfig
> builds for all recent architectures:
> 
> dec/tulip/winbond-840.c:910:2: warning: #warning Processor architecture undefined
> dec/tulip/tulip_core.c:101:2: warning: #warning Processor architecture undefined!
> 
> This is the last remaining warning for arm64, and I'd like to get rid of
> it. We don't really know the cache line size, architecturally it would
> be at least 16 bytes, but all implementations I found have 64 or 128
> bytes. Configuring tulip for 32-byte lines as we do on ARM32 seems to
> be the safe but slow default, and nobody who cares about performance these
> days would use a tulip chip anyway, so we can just use that.
> 
> To save the next person the job of trying to find out what this is for
> and picking a default for their architecture just to kill off the warning,
> I'm now removing the preprocessor #warning and turning it into a pr_warn
> or dev_warn that prints the equivalent information when the driver gets
> loaded.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Seems reasonable, applied, thanks Arnd!

      parent reply	other threads:[~2015-11-20 16:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 10:42 [PATCH] net: tulip: turn compile-time warning into dev_warn() Arnd Bergmann
2015-11-19 12:26 ` Will Deacon
2015-11-19 20:29   ` Florian Fainelli
2015-11-19 21:57     ` Grant Grundler
2015-11-19 23:50       ` Francois Romieu
2015-11-20  1:41         ` Grant Grundler
2015-11-19 21:37   ` Grant Grundler
2015-11-20 16:03 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151120.110314.213434169745300737.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=grundler@parisc-linux.org \
    --cc=netdev@vger.kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.