From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1162666AbbKTMG3 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Nov 2015 07:06:29 -0500
Received: from mail.kernel.org ([198.145.29.136]:40994 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1161907AbbKTMG0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Nov 2015 07:06:26 -0500
Date: Fri, 20 Nov 2015 09:06:22 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Kan Liang <kan.liang@intel.com>
Subject: Re: [PATCH v5 4/9] perf report: Add callchain value option
Message-ID: <20151120120622.GH29361@kernel.org>
References: <1447047946-1691-1-git-send-email-namhyung@kernel.org>
 <1447047946-1691-6-git-send-email-namhyung@kernel.org>
 <20151119135914.GB29361@kernel.org>
 <20151120013947.GB23310@sejong>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151120013947.GB23310@sejong>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Fri, Nov 20, 2015 at 10:39:47AM +0900, Namhyung Kim escreveu:
> On Thu, Nov 19, 2015 at 10:59:14AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Nov 09, 2015 at 02:45:41PM +0900, Namhyung Kim escreveu:
> > > Now -g/--call-graph option supports how to display callchain values.
> > > Possible values are 'percent', 'period' and 'count'.  The percent is
> > > same as before and it's the default behavior.  The period displays the
> > > raw period value rather than the percentage.  The count displays the
> > > number of occurrences.
> > > 
> > >   $ perf report --no-children --stdio -g percent
> > >   ...
> > >     39.93%  swapper  [kernel.vmlinux]  [k] intel_idel
> > >             |
> > >             ---intel_idle
> > >                cpuidle_enter_state
> > >                cpuidle_enter
> > >                call_cpuidle
> > >                cpu_startup_entry
> > >                |
> > >                |--28.63%-- start_secondary
> > >                |
> > >                 --11.30%-- rest_init
> > 
> > So, if I try to do:
> > 
> >   perf report --no-children --stdio -g percent,count
> > 
> > It shows just 'count', i.e. the last of these options, is this an
> > intended limitation?
> > 
> > I'm applying it as-is, but I can see no reason why we wouldn't want to
> > lift this limitation.
> 
> 
> Hmm.. I expected just one value type is used, but yes, we might want
> to support to print multiple values if needed.

And at least to warn the user when more than one out of those options is
asked for and just one of them ends up in the output.

- Arnaldo