From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759362AbbKTPpH (ORCPT ); Fri, 20 Nov 2015 10:45:07 -0500 Received: from mail.kernel.org ([198.145.29.136]:57422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbbKTPpD (ORCPT ); Fri, 20 Nov 2015 10:45:03 -0500 Date: Fri, 20 Nov 2015 09:44:58 -0600 From: Rob Herring To: Irina Tirdea Cc: Dmitry Torokhov , Bastien Nocera , Aleksei Mamlin , Karsten Merker , linux-input@vger.kernel.org, Mark Rutland , Octavian Purdila , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v11 6/8] Input: goodix - add support for ESD Message-ID: <20151120154458.GA12090@rob-hp-laptop> References: <1447936001-21420-1-git-send-email-irina.tirdea@intel.com> <1447936001-21420-7-git-send-email-irina.tirdea@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447936001-21420-7-git-send-email-irina.tirdea@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 19, 2015 at 02:26:39PM +0200, Irina Tirdea wrote: > Add ESD (Electrostatic Discharge) protection mechanism. [...] > This is based on Goodix datasheets for GT911 and GT9271 and on Goodix > driver gt9xx.c for Android (publicly available in Android kernel > trees for various devices). > > Signed-off-by: Irina Tirdea > For the binding: Acked-by: Rob Herring You should not have the "For the binding:" part here. It was just a note so it was clear what part I looked at. It is preferred to split DT bindings to separate patches for this reason. > Signed-off-by: Irina Tirdea > --- > .../bindings/input/touchscreen/goodix.txt | 4 + > drivers/input/touchscreen/goodix.c | 160 ++++++++++++++++++++- > 2 files changed, 159 insertions(+), 5 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v11 6/8] Input: goodix - add support for ESD Date: Fri, 20 Nov 2015 09:44:58 -0600 Message-ID: <20151120154458.GA12090@rob-hp-laptop> References: <1447936001-21420-1-git-send-email-irina.tirdea@intel.com> <1447936001-21420-7-git-send-email-irina.tirdea@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1447936001-21420-7-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Irina Tirdea Cc: Dmitry Torokhov , Bastien Nocera , Aleksei Mamlin , Karsten Merker , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Rutland , Octavian Purdila , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Nov 19, 2015 at 02:26:39PM +0200, Irina Tirdea wrote: > Add ESD (Electrostatic Discharge) protection mechanism. [...] > This is based on Goodix datasheets for GT911 and GT9271 and on Goodix > driver gt9xx.c for Android (publicly available in Android kernel > trees for various devices). > > Signed-off-by: Irina Tirdea > For the binding: Acked-by: Rob Herring You should not have the "For the binding:" part here. It was just a note so it was clear what part I looked at. It is preferred to split DT bindings to separate patches for this reason. > Signed-off-by: Irina Tirdea > --- > .../bindings/input/touchscreen/goodix.txt | 4 + > drivers/input/touchscreen/goodix.c | 160 ++++++++++++++++++++- > 2 files changed, 159 insertions(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html