From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754807AbbKXTfG (ORCPT ); Tue, 24 Nov 2015 14:35:06 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:45119 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753083AbbKXTfD (ORCPT ); Tue, 24 Nov 2015 14:35:03 -0500 Date: Tue, 24 Nov 2015 14:35:00 -0500 (EST) Message-Id: <20151124.143500.2270041277109978016.davem@davemloft.net> To: saurabh.truth@gmail.com Cc: isubramanian@apm.com, kchudgar@apm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: net: xgene: optimizing the code From: David Miller In-Reply-To: <1448285535-4514-1-git-send-email-saurabh.truth@gmail.com> References: <1448285535-4514-1-git-send-email-saurabh.truth@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Nov 2015 11:35:02 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Saurabh Sengar Date: Mon, 23 Nov 2015 19:02:15 +0530 > this patch does the following: > 1 . remove unnecessary if, else condition > 2 . reduce one variable > 3 . change the return type of 2 functions to void as there return values > turn out to be 0 always after above changes > > Signed-off-by: Saurabh Sengar This looks fine, applied, thanks.