From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755112AbbKXVac (ORCPT ); Tue, 24 Nov 2015 16:30:32 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:46142 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755085AbbKXVa2 (ORCPT ); Tue, 24 Nov 2015 16:30:28 -0500 Date: Tue, 24 Nov 2015 16:30:25 -0500 (EST) Message-Id: <20151124.163025.1551408934471757005.davem@davemloft.net> To: herbert@gondor.apana.org.au Cc: peterz@infradead.org, tatsu@ab.jp.nec.com, mingo@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jolsa@redhat.com, eric.dumazet@gmail.com Subject: Re: net: Generalise wq_has_sleeper helper From: David Miller In-Reply-To: <20151124055423.GA31611@gondor.apana.org.au> References: <20151023124006.GA17308@twins.programming.kicks-ass.net> <20151111094829.GA23202@gondor.apana.org.au> <20151124055423.GA31611@gondor.apana.org.au> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Nov 2015 13:30:27 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Herbert Xu Date: Tue, 24 Nov 2015 13:54:23 +0800 > On Wed, Nov 11, 2015 at 05:48:29PM +0800, Herbert Xu wrote: >> >> BTW, the networking folks found this years ago and even added >> helpers to deal with this. See for example wq_has_sleeper in >> include/net/sock.h. It would be good if we can move some of >> those helpers into wait.h instead. > > Here is a patch against net-next which makes the wq_has_sleeper > helper available to non-next users: > > ---8<--- > The memory barrier in the helper wq_has_sleeper is needed by just > about every user of waitqueue_active. This patch generalises it > by making it take a wait_queue_head_t directly. The existing > helper is renamed to skwq_has_sleeper. > > Signed-off-by: Herbert Xu I'm fine with wherever this patch goes. Herbert is there any particular tree where it'll facilitate another user quickest? Or should I just toss it into net-next? Acked-by: David S. Miller