All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Sreekanth.Reddy@avagotech.com, hare@suse.de,
	martin.petersen@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: MPT2SAS boot fail... due to silently loosing the driver
Date: Tue, 24 Nov 2015 09:04:29 +0100	[thread overview]
Message-ID: <20151124080429.GA3398@gmail.com> (raw)
In-Reply-To: <20151124075149.GB29572@lst.de>


* Christoph Hellwig <hch@lst.de> wrote:

> I wonder what the "classic" way to such transitions is.  Adding a mpt2 option 
> that just selects mpt3 sound easy, but might be very confusing.

I was hit by the same problem, and wasted some time on it before Peter did his 
time wasting, so a solution would be nice.

An interactive SCSI_MPT2SAS option has to exist in any case, so that we can 
migrate those people who have it configured - and its help text should explain 
that it's a legacy setting that should not be used anymore. That won't be 
confusing.

Then the MPT3 section can do something like:

	# Default to enabled if the config has the old driver enabled:
	default y if SCSI_MPT2SAS

Doing this will also help bisectability: right now we cannot bisect on that system 
without figuring out whether to enable MPT2 or MPT3 at every single bisection 
step.

Don't ever break configs this way. Please!

Also, please pick hardware version invariant names - do we want to go through this 
again when MPT4 is introduced?

Thanks,

	Ingo

  parent reply	other threads:[~2015-11-24  8:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23 12:46 MPT2SAS boot fail... due to silently loosing the driver Peter Zijlstra
2015-11-24  7:51 ` Christoph Hellwig
2015-11-24  7:54   ` Hannes Reinecke
2015-11-24  7:56     ` Christoph Hellwig
2015-11-24  8:04   ` Ingo Molnar [this message]
2015-11-24 12:02 ` Martin K. Petersen
2015-11-26 10:48   ` Ingo Molnar
2015-11-30 17:21     ` Martin K. Petersen
2015-11-30 17:24       ` Christoph Hellwig
2015-11-30 17:27       ` James Bottomley
2015-12-01  9:49       ` Sreekanth Reddy
2015-12-02  9:57       ` Ingo Molnar
2015-11-26 10:51   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151124080429.GA3398@gmail.com \
    --to=mingo@kernel.org \
    --cc=Sreekanth.Reddy@avagotech.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.