From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41081)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a1EKd-0007n6-Ix
	for qemu-devel@nongnu.org; Tue, 24 Nov 2015 09:12:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a1EKY-00087o-JU
	for qemu-devel@nongnu.org; Tue, 24 Nov 2015 09:12:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38769)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a1EKY-00087j-Ee
	for qemu-devel@nongnu.org; Tue, 24 Nov 2015 09:12:26 -0500
Date: Tue, 24 Nov 2015 16:12:22 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151124161104-mutt-send-email-mst@redhat.com>
References: <1447694618-17177-3-git-send-email-marcandre.lureau@redhat.com>
	<1447837378-25222-1-git-send-email-marcandre.lureau@redhat.com>
	<20151118224821-mutt-send-email-mst@redhat.com>
	<56534FAA.4090101@redhat.com>
	<CAJ+F1CJsL=WVfY7Gj7yU0UTOfp06egeLseMXBX5DJsr=3YBAjA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <CAJ+F1CJsL=WVfY7Gj7yU0UTOfp06egeLseMXBX5DJsr=3YBAjA@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] exec: silence hugetlbfs warning under qtest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>
Cc: Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, QEMU <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

On Mon, Nov 23, 2015 at 07:01:33PM +0100, Marc-Andr=E9 Lureau wrote:
> On Mon, Nov 23, 2015 at 6:40 PM, Paolo Bonzini <pbonzini@redhat.com> wr=
ote:
> > Before: object-initial, chardev, qtest, object-late (not in the patch=
)
> >
> > After: chardev, qtest, object-initial, object-late (not in the patch)
> >
> > Objects must be initialized before chardev (except rng-egd) since in =
the
> > future chardev will need to use objects, in particular secret objects=
.
> > Was the swap intentional?
>=20
> Yes, without the swap, qtest was not initialized before memory is alloc=
ated.
>=20
> The alternative I could think of is to check the QTEST_QEMU_BINARY
> variable: http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg01=
527.html

Better add a custom flag just for running tests.
environment setting are too fragile.

>=20
> --=20
> Marc-Andr=E9 Lureau