From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a1FX3-00045J-9Y
	for qemu-devel@nongnu.org; Tue, 24 Nov 2015 10:29:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a1FWy-00030E-NJ
	for qemu-devel@nongnu.org; Tue, 24 Nov 2015 10:29:25 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60956)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a1FWy-000305-Im
	for qemu-devel@nongnu.org; Tue, 24 Nov 2015 10:29:20 -0500
Date: Tue, 24 Nov 2015 17:29:16 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151124172550-mutt-send-email-mst@redhat.com>
References: <1447694618-17177-3-git-send-email-marcandre.lureau@redhat.com>
	<1447837378-25222-1-git-send-email-marcandre.lureau@redhat.com>
	<20151118224821-mutt-send-email-mst@redhat.com>
	<56534FAA.4090101@redhat.com>
	<CAJ+F1CJsL=WVfY7Gj7yU0UTOfp06egeLseMXBX5DJsr=3YBAjA@mail.gmail.com>
	<20151123181008.GU18085@redhat.com>
	<20151124160921-mutt-send-email-mst@redhat.com>
	<20151124141936.GJ9981@redhat.com>
	<20151124162004-mutt-send-email-mst@redhat.com>
	<5654747F.9050004@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5654747F.9050004@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] exec: silence hugetlbfs warning under qtest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>, QEMU <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

On Tue, Nov 24, 2015 at 03:30:23PM +0100, Paolo Bonzini wrote:
> 
> 
> On 24/11/2015 15:25, Michael S. Tsirkin wrote:
> > I'm worried that things go slow and people don't have a way to find out
> > why, and documentation isn't the first place people look for when facing
> > a performance issue.
> > 
> > At the moment we call MADV_HUGEPAGE unconditionally and unfortunately
> > there's no way to report it's not having the intended effect.
> > 
> > Maybe we want a "don't enable hugepages" flag.
> > That could also have the effect of suppressing the warnings.
> 
> THP is anyway slower than hugetlbfs.  If people really want performance,
> they need to use hugetlbfs.  For everything else I'd be surprised if
> they even notice.
> 
> Paolo

If you want to post and merge a patch removing this warning completely,
and revert the original one, that's fine with me.

-- 
MST