From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Or Gerlitz <ogerlitz@mellanox.com>,
Sagi Grimberg <sagig@mellanox.com>,
linux-rdma@vger.kernel.org, target-devel@vger.kernel.org,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Steve Wise <swise@opengridcomputing.com>,
Jenny Derzhavetz <jennyf@mellanox.com>
Subject: Re: [PATCH for-next 03/10] IB/iser: Don't register memory for all immediatedata writes
Date: Tue, 24 Nov 2015 11:15:56 -0700 [thread overview]
Message-ID: <20151124181556.GE10391@obsidianresearch.com> (raw)
In-Reply-To: <56543634.4090605@dev.mellanox.co.il>
On Tue, Nov 24, 2015 at 12:04:36PM +0200, Sagi Grimberg wrote:
> Jason and Or,
>
> >
> >I'm with Or on this, this is really goofy looking.
> >
> >This routine probably should not be setting the rkey at all, it makes
> >no sense to have a routine that returns a lkey and a rkey. Those are
> >always different flows.
> >
> >Once that is fixed then the above if can be hoisted to the actual
> >calling code that needs an rkey, at the point where it does something
> >different when !iser_always_reg is true..
>
> This change is acceptable to me. However, given that it includes
> rework outside the scope of this specific patch which is a performance
> regression fix, would it be acceptable to have it incremental and
> provide a FIXME comment here?
I'm not bothered by the ordering as long as we are clear where things
are going :)
Jason
next prev parent reply other threads:[~2015-11-24 18:15 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 16:37 [PATCH for-next 00/10] iSER support for remote invalidate Sagi Grimberg
2015-11-16 16:37 ` [PATCH for-next 01/10] IB/iser: Fix module init not cleaning up on error flow Sagi Grimberg
[not found] ` <1447691861-3796-2-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 6:53 ` Or Gerlitz
[not found] ` <564ACEF7.8030809-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 9:31 ` Sagi Grimberg
2015-11-17 8:56 ` Christoph Hellwig
2015-11-16 16:37 ` [PATCH for-next 02/10] IB/iser: Default to fastreg instead of fmr Sagi Grimberg
[not found] ` <1447691861-3796-3-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 7:41 ` Or Gerlitz
2015-11-17 9:35 ` Sagi Grimberg
2015-11-17 10:09 ` Or Gerlitz
2015-11-17 10:46 ` Sagi Grimberg
2015-11-17 8:57 ` Christoph Hellwig
2015-11-17 9:35 ` Sagi Grimberg
[not found] ` <1447691861-3796-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-16 16:37 ` [PATCH for-next 03/10] IB/iser: Don't register memory for all immediatedata writes Sagi Grimberg
2015-11-17 7:47 ` Or Gerlitz
[not found] ` <564ADB7D.20806-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 9:41 ` Sagi Grimberg
[not found] ` <564AF653.6060401-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-11-17 10:11 ` Or Gerlitz
[not found] ` <564AFD4A.4030300-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 10:15 ` Sagi Grimberg
2015-11-23 18:13 ` Jason Gunthorpe
2015-11-24 10:04 ` Sagi Grimberg
2015-11-24 18:15 ` Jason Gunthorpe [this message]
2015-11-16 16:37 ` [PATCH for-next 07/10] iser-target: Declare correct flags when accepting a connection Sagi Grimberg
[not found] ` <1447691861-3796-8-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 7:59 ` Or Gerlitz
[not found] ` <564ADE63.3030901-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 9:48 ` Sagi Grimberg
[not found] ` <564AF808.7010404-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-11-17 10:13 ` Or Gerlitz
2015-11-17 9:03 ` Christoph Hellwig
2015-11-17 9:38 ` Sagi Grimberg
2015-11-16 16:37 ` [PATCH for-next 09/10] IB/iser: Increment the rkey when registering and not when invalidating Sagi Grimberg
2015-11-17 8:13 ` Or Gerlitz
2015-11-17 8:10 ` [PATCH for-next 00/10] iSER support for remote invalidate Or Gerlitz
[not found] ` <564AE0E8.7030705-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 9:56 ` Sagi Grimberg
2015-11-16 16:37 ` [PATCH for-next 04/10] IB/iser: set intuitive values for mr_valid Sagi Grimberg
2015-11-17 7:43 ` Or Gerlitz
[not found] ` <564ADAB5.3080208-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 9:43 ` Sagi Grimberg
2015-11-16 16:37 ` [PATCH for-next 05/10] iser: Have initiator and target to share protocol structures and definitions Sagi Grimberg
2015-11-17 8:59 ` Christoph Hellwig
[not found] ` <20151117085933.GC19578-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-17 9:58 ` Sagi Grimberg
[not found] ` <564AFA42.5060808-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-11-17 10:07 ` Christoph Hellwig
[not found] ` <1447691861-3796-6-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-19 7:20 ` Or Gerlitz
[not found] ` <564D7835.4010407-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-19 8:40 ` Sagi Grimberg
2015-11-16 16:37 ` [PATCH for-next 06/10] iser-target: Remove unused file iser_proto.h Sagi Grimberg
2015-11-17 7:57 ` Or Gerlitz
2015-11-17 9:45 ` Sagi Grimberg
2015-11-17 9:00 ` Christoph Hellwig
[not found] ` <20151117090046.GD19578-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-17 9:46 ` Sagi Grimberg
2015-11-16 16:37 ` [PATCH for-next 08/10] iser-target: Support the remote invalidation exception Sagi Grimberg
[not found] ` <1447691861-3796-9-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 8:09 ` Or Gerlitz
[not found] ` <564AE0C6.2030203-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 9:50 ` Sagi Grimberg
[not found] ` <564AF857.5090701-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-11-17 10:05 ` Or Gerlitz
2015-11-17 10:14 ` Christoph Hellwig
2015-11-17 10:16 ` Sagi Grimberg
2015-11-19 7:25 ` Or Gerlitz
2015-11-16 16:37 ` [PATCH for-next 10/10] IB/iser: " Sagi Grimberg
[not found] ` <1447691861-3796-11-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 8:03 ` Or Gerlitz
[not found] ` <564ADF68.1050408-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 9:50 ` Sagi Grimberg
2015-11-17 8:05 ` Or Gerlitz
2015-11-17 9:53 ` Sagi Grimberg
2015-11-17 10:04 ` Or Gerlitz
2015-11-17 10:15 ` Christoph Hellwig
[not found] ` <564AFB93.9010602-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 10:26 ` Sagi Grimberg
[not found] ` <564B00C3.1030506-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-11-17 16:53 ` Or Gerlitz
2015-11-18 11:38 ` Sagi Grimberg
2015-11-18 13:33 ` Or Gerlitz
2015-11-18 13:52 ` Christoph Hellwig
[not found] ` <20151118135237.GA3214-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-18 13:58 ` Or Gerlitz
[not found] ` <CAJ3xEMiBwowDFPEVqjKr-DMeDiWih8qbwshP2QbaH_56aNsRDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-18 14:10 ` Christoph Hellwig
[not found] ` <20151118141023.GA10198-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-19 7:12 ` Or Gerlitz
[not found] ` <564D7653.8070101-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-19 9:15 ` Sagi Grimberg
2015-11-19 10:01 ` Christoph Hellwig
[not found] ` <20151119100106.GA24120-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-19 11:17 ` Or Gerlitz
[not found] ` <CAJ3xEMhxOQ-HXKiXuBOKNet0VeDbNQingphFvzUXBiLcDjCmNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-18 14:16 ` Sagi Grimberg
2015-11-19 7:16 ` Or Gerlitz
2015-11-17 8:08 ` Or Gerlitz
[not found] ` <564AE06C.9020504-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 9:55 ` Sagi Grimberg
2015-11-17 9:35 ` [PATCH for-next 00/10] iSER support for remote invalidate Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124181556.GE10391@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jennyf@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=ogerlitz@mellanox.com \
--cc=sagig@dev.mellanox.co.il \
--cc=sagig@mellanox.com \
--cc=swise@opengridcomputing.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.