All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: larsxschneider@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH v7 1/2] config.mak.uname: Darwin: define NO_GETTEXT for OS X 10.9 and later
Date: Tue, 24 Nov 2015 15:34:53 -0500	[thread overview]
Message-ID: <20151124203453.GB7174@sigill.intra.peff.net> (raw)
In-Reply-To: <5652FF18.20602@web.de>

On Mon, Nov 23, 2015 at 12:57:12PM +0100, Torsten Bögershausen wrote:

> >+	# MacOS 10.7 Lion and higher
> >  	ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 11 && echo 1),1)
> >  		HAVE_GETDELIM = YesPlease
> >  	endif
> >+	# MacOS 10.9 Mavericks and higher
> >+	ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 13 && echo 1),1)
> >+		NO_GETTEXT = YesPlease
> >+	endif
> >  	NO_MEMMEM = YesPlease
> >  	USE_ST_TIMESPEC = YesPlease
> >  	HAVE_DEV_TTY = YesPlease
> Unless I'm wrong, no Mac OS X had libintl.h, and the "unwritten agreement
> (?)" was
> that either
> a) libintl ist installed in some way (fink, mac ports, brew, other ways)
> or
> b) people use
> NO_GETTEXT=yes make
> 
> Doesn't this patch close the door for b), making it impossible to build Git
> against libintl ?

I think the right way to do (b) is:

  make NO_GETTEXT=Yes

which will override anything we do in config.mak.uname (and likewise,
anything from autoconf will override it, if we have a test there).

Still, it will be a surprise to packagers in (a), who assume that
installing libintl and then building git is enough to have gettext
support (now they would actively need to override NO_GETTEXT).

-Peff

  reply	other threads:[~2015-11-24 20:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23  8:25 [PATCH v7 0/2] Add Travis CI support larsxschneider
2015-11-23  8:25 ` [PATCH v7 1/2] config.mak.uname: Darwin: define NO_GETTEXT for OS X 10.9 and later larsxschneider
2015-11-23 11:57   ` Torsten Bögershausen
2015-11-24 20:34     ` Jeff King [this message]
2015-11-23  8:25 ` [PATCH v7 2/2] Add Travis CI support larsxschneider
2015-11-24 20:40   ` Jeff King
2015-11-24 21:03     ` Lars Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151124203453.GB7174@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=larsxschneider@gmail.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.