From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932117AbbKXVOQ (ORCPT ); Tue, 24 Nov 2015 16:14:16 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:43254 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754695AbbKXVOO (ORCPT ); Tue, 24 Nov 2015 16:14:14 -0500 Date: Tue, 24 Nov 2015 22:14:08 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Guenter Roeck Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck , linux-kernel@vger.kernel.org, Timo Kokkonen , linux-doc@vger.kernel.org, Jonathan Corbet Subject: Re: [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core Message-ID: <20151124211408.GI19888@pengutronix.de> References: <1448248865-21684-1-git-send-email-linux@roeck-us.net> <1448248865-21684-2-git-send-email-linux@roeck-us.net> <20151124071628.GF19888@pengutronix.de> <56547C31.3070901@roeck-us.net> <20151124161147.GH19888@pengutronix.de> <56549411.7000209@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56549411.7000209@roeck-us.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Guenter, On Tue, Nov 24, 2015 at 08:45:05AM -0800, Guenter Roeck wrote: > On 11/24/2015 08:11 AM, Uwe Kleine-König wrote: > >On Tue, Nov 24, 2015 at 07:03:13AM -0800, Guenter Roeck wrote: > >>thanks a lot for the Ack. I have v6 in the works, which changes recording > >>of last_keepalive when the watchdog is started. Does your Ack include that > >>change, or do you prefer to have another look ? > > > >this change is to sample jiffies before .start is called as I suggested, > >right? For that change keeping my ack is ok of course. > > > > Correct. This is how the code now looks like. > > started_at = jiffies; > if (watchdog_hw_running(wdd) && wdd->ops->ping) > err = wdd->ops->ping(wdd); > else > err = wdd->ops->start(wdd); > if (err == 0) { > set_bit(WDOG_ACTIVE, &wdd->status); > wdd->last_keepalive = started_at; > watchdog_update_worker(wdd); > } \o/ Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |