From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932285AbbKXV4R (ORCPT ); Tue, 24 Nov 2015 16:56:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:45019 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932079AbbKXVwv (ORCPT ); Tue, 24 Nov 2015 16:52:51 -0500 Date: Tue, 24 Nov 2015 13:52:50 -0800 From: Mark Fasheh To: Gang He Cc: rgoldwyn@suse.de, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check Message-ID: <20151124215250.GV15575@wotan.suse.de> Reply-To: Mark Fasheh References: <1446013561-22121-1-git-send-email-ghe@suse.com> <1446013561-22121-3-git-send-email-ghe@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446013561-22121-3-git-send-email-ghe@suse.com> Organization: SUSE Labs User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2015 at 02:25:59PM +0800, Gang He wrote: > Implement online file check sysfile interfaces, e.g. > how to create the related sysfile according to device name, > how to display/handle file check request from the sysfile. > > Signed-off-by: Gang He FYI, This looks generally fine to me however we should address Junxiao's concerns before it goes any further. --Mark -- Mark Fasheh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Fasheh Date: Tue, 24 Nov 2015 13:52:50 -0800 Subject: [Ocfs2-devel] [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check In-Reply-To: <1446013561-22121-3-git-send-email-ghe@suse.com> References: <1446013561-22121-1-git-send-email-ghe@suse.com> <1446013561-22121-3-git-send-email-ghe@suse.com> Message-ID: <20151124215250.GV15575@wotan.suse.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Gang He Cc: rgoldwyn@suse.de, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com On Wed, Oct 28, 2015 at 02:25:59PM +0800, Gang He wrote: > Implement online file check sysfile interfaces, e.g. > how to create the related sysfile according to device name, > how to display/handle file check request from the sysfile. > > Signed-off-by: Gang He FYI, This looks generally fine to me however we should address Junxiao's concerns before it goes any further. --Mark -- Mark Fasheh