From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] mk: fix the combined library problems by replacing it with a linker script Date: Wed, 25 Nov 2015 08:08:37 -0800 Message-ID: <20151125080837.68e24a2d@xeon-e3> References: <079fa1cfc3550c8147ea8b137fa1bc0f34d051dc.1448375477.git.pmatilai@redhat.com> <20151124144638.0b659e7d@xeon-e3> <56557398.3020600@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Panu Matilainen Return-path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id B0680923A for ; Wed, 25 Nov 2015 17:08:28 +0100 (CET) Received: by pacdm15 with SMTP id dm15so61378585pac.3 for ; Wed, 25 Nov 2015 08:08:28 -0800 (PST) In-Reply-To: <56557398.3020600@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 25 Nov 2015 10:38:48 +0200 Panu Matilainen wrote: > On 11/25/2015 12:46 AM, Stephen Hemminger wrote: > > On Tue, 24 Nov 2015 16:31:17 +0200 > > Panu Matilainen wrote: > > > >> The physically linked-together combined library has been an increasing > >> source of problems, as was predicted when library and symbol versioning > >> was introduced. Replace the complex and fragile construction with a > >> simple linker script which achieves the same without all the problems, > >> remove the related kludges from eg mlx drivers. > >> > >> Since creating the linker script is practically zero cost, remove the > >> config option and just create it always. > >> > >> Based on a patch by Sergio Gonzales Monroy, linker script approach > >> initially suggested by Neil Horman. > >> > >> Suggested-by: Sergio Gonzalez Monroy > >> Suggested-by: Neil Horman > >> Signed-off-by: Panu Matilainen > > > > But it now means distros have to ship 20 libraries which seems like > > a step back. > > That's how Fedora and RHEL are shipping it already and nobody has so > much as noticed anything strange, much less complained about it. 20 > libraries is but a drop in the ocean on a average distro. But more to > the point, distros will prefer 50 working libraries over one that doesn't. > > The combined library as it is simply is no longer a viable option. > Besides just being broken (witness the strange hacks people are coming > up with to work around issues in it) its ugly because it basically gives > the middle finger to all the effort going into version compatibility, > and its also big. Few projects will use every library in DPDK, but with > the combined library they're forced to lug the 800 pound gorilla along > needlessly. > > - Panu - > Fixing the combined library took less than an hour for us.