From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH for-next V1 9/9] IB/cma: Join and leave multicast groups with IGMP Date: Wed, 25 Nov 2015 10:39:04 -0700 Message-ID: <20151125173904.GB3223@obsidianresearch.com> References: <1444925232-13598-1-git-send-email-matanb@mellanox.com> <1444925232-13598-10-git-send-email-matanb@mellanox.com> <20151123212526.GD6062@obsidianresearch.com> <20151124181500.GD10391@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Moni Shoua Cc: Matan Barak , Doug Ledford , linux-rdma , Or Gerlitz , Eran Ben Elisha , Somnath Kotur List-Id: linux-rdma@vger.kernel.org On Wed, Nov 25, 2015 at 10:31:15AM +0200, Moni Shoua wrote: > On Tue, Nov 24, 2015 at 8:15 PM, Jason Gunthorpe > wrote: > > On Tue, Nov 24, 2015 at 11:41:10AM +0200, Moni Shoua wrote: > >> On Mon, Nov 23, 2015 at 11:25 PM, Jason Gunthorpe > >> wrote: > >> > On Thu, Oct 15, 2015 at 07:07:12PM +0300, Matan Barak wrote: > >> >> diff --git a/include/rdma/ib_sa.h b/include/rdma/ib_sa.h > >> >> index 0a40ed2..5bea0e8 100644 > >> >> +++ b/include/rdma/ib_sa.h > >> >> @@ -206,6 +206,9 @@ struct ib_sa_mcmember_rec { > >> >> u8 scope; > >> >> u8 join_state; > >> >> int proxy_join; > >> >> + int ifindex; > >> >> + struct net *net; > >> >> + enum ib_gid_type gid_type; > >> >> }; > >> > > >> > This is really gross. > >> > > >> > Make ib_init_ah_from_mcmember accept a QP and get the above stuff from > >> > the QP. > >> > > >> > Jason > >> > >> Which QP is that. You might not have any existing QP when you want to > >> create the AH or you might have 10. > > > > roce multicast is only done with the CM and the CM always has a QP. > > > I don't see why you can't join before having a QP and anyway, > rdma_create_qp() is optional Ugh, gross, why would anyone want to do that.. Doesn't change my point, the CM id is bound before multicast join can run, don't pollute ib_sa_mcmember_rec with this. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html