From mboxrd@z Thu Jan 1 00:00:00 1970 From: mcgrof@suse.com (Luis R. Rodriguez) Date: Wed, 25 Nov 2015 20:36:51 +0100 Subject: [Cocci] [Xen-devel] [PATCH 2/9] Use gnutls_priority_set_direct() to deprecate gnutls_*_set() In-Reply-To: <20151125145322.GA24630@x230.dumpdata.com> References: <1448041672-3986-1-git-send-email-mcgrof@do-not-panic.com> <1448041672-3986-3-git-send-email-mcgrof@do-not-panic.com> <20151125145322.GA24630@x230.dumpdata.com> Message-ID: <20151125193651.GH9528@wotan.suse.de> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr On Wed, Nov 25, 2015 at 09:53:27AM -0500, Konrad Rzeszutek Wilk wrote: > On Fri, Nov 20, 2015 at 09:47:45AM -0800, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > > > Using deprecate gnutls_*_set() triggers a failure to compile > > with gnutls30-3.4.4, used on OpenSUSE factory: > > > > ../libqemu_common.a(vnc.o): In function `vnc_start_tls': > > ~/devel/xen/tools/qemu-xen-traditional-dir/vnc.c:2164: undefined reference to `gnutls_kx_set_priority' > > ~/devel/xen/tools/qemu-xen-traditional-dir/vnc.c:2171: undefined reference to `gnutls_certificate_type_set_priority' > > ~/devel/xen/tools/qemu-xen-traditional-dir/vnc.c:2178: undefined reference to `gnutls_protocol_set_priority' > > > > This compilation issue can be fixed by using the new routine > > gnutls_priority_set_direct() which replaces the deprecated calls > > which also simplifies the code considerably. > > > Thanks for posting that! It certainly fixes that issue. Acked-by? > I was wondering if you had seen these as well: > > /home/konrad/qemu-trad.git/vnc.c:1929:1: warning: > ?gnutls_anon_server_credentials? is deprecated > [-Wdeprecated-declarations] > { > ^ > /home/konrad/qemu-trad.git/vnc.c: In function > ?vnc_tls_initialize_anon_cred?: > /home/konrad/qemu-trad.git/vnc.c:1930:5: warning: > ?gnutls_anon_server_credentials? is deprecated > [-Wdeprecated-declarations] > gnutls_anon_server_credentials anon_cred; > ^ > /home/konrad/qemu-trad.git/vnc.c: In function ?vnc_start_tls?: > /home/konrad/qemu-trad.git/vnc.c:2203:6: warning: > ?gnutls_anon_server_credentials? is deprecated > [-Wdeprecated-declarations] > gnutls_anon_server_credentials anon_cred = > vnc_tls_initialize_anon_cred(); > ^ > ? > > (This is Fedora 23) Nope. Luis From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [Xen-devel] [PATCH 2/9] Use gnutls_priority_set_direct() to deprecate gnutls_*_set() Date: Wed, 25 Nov 2015 20:36:51 +0100 Message-ID: <20151125193651.GH9528@wotan.suse.de> References: <1448041672-3986-1-git-send-email-mcgrof@do-not-panic.com> <1448041672-3986-3-git-send-email-mcgrof@do-not-panic.com> <20151125145322.GA24630@x230.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20151125145322.GA24630@x230.dumpdata.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xensource.com, ian.campbell@citrix.com, pryorm09@gmail.com, cfergeau@redhat.com, JBeulich@suse.com, samuel.thibault@ens-lyon.org, cocci@systeme.lip6.fr List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBOb3YgMjUsIDIwMTUgYXQgMDk6NTM6MjdBTSAtMDUwMCwgS29ucmFkIFJ6ZXN6dXRl ayBXaWxrIHdyb3RlOgo+IE9uIEZyaSwgTm92IDIwLCAyMDE1IGF0IDA5OjQ3OjQ1QU0gLTA4MDAs IEx1aXMgUi4gUm9kcmlndWV6IHdyb3RlOgo+ID4gRnJvbTogIkx1aXMgUi4gUm9kcmlndWV6IiA8 bWNncm9mQHN1c2UuY29tPgo+ID4gCj4gPiBVc2luZyBkZXByZWNhdGUgZ251dGxzXypfc2V0KCkg dHJpZ2dlcnMgYSBmYWlsdXJlIHRvIGNvbXBpbGUKPiA+IHdpdGggZ251dGxzMzAtMy40LjQsIHVz ZWQgb24gT3BlblNVU0UgZmFjdG9yeToKPiA+IAo+ID4gLi4vbGlicWVtdV9jb21tb24uYSh2bmMu byk6IEluIGZ1bmN0aW9uIGB2bmNfc3RhcnRfdGxzJzoKPiA+IH4vZGV2ZWwveGVuL3Rvb2xzL3Fl bXUteGVuLXRyYWRpdGlvbmFsLWRpci92bmMuYzoyMTY0OiB1bmRlZmluZWQgcmVmZXJlbmNlIHRv IGBnbnV0bHNfa3hfc2V0X3ByaW9yaXR5Jwo+ID4gfi9kZXZlbC94ZW4vdG9vbHMvcWVtdS14ZW4t dHJhZGl0aW9uYWwtZGlyL3ZuYy5jOjIxNzE6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYGdudXRs c19jZXJ0aWZpY2F0ZV90eXBlX3NldF9wcmlvcml0eScKPiA+IH4vZGV2ZWwveGVuL3Rvb2xzL3Fl bXUteGVuLXRyYWRpdGlvbmFsLWRpci92bmMuYzoyMTc4OiB1bmRlZmluZWQgcmVmZXJlbmNlIHRv IGBnbnV0bHNfcHJvdG9jb2xfc2V0X3ByaW9yaXR5Jwo+ID4gCj4gPiBUaGlzIGNvbXBpbGF0aW9u IGlzc3VlIGNhbiBiZSBmaXhlZCBieSB1c2luZyB0aGUgbmV3IHJvdXRpbmUKPiA+IGdudXRsc19w cmlvcml0eV9zZXRfZGlyZWN0KCkgd2hpY2ggcmVwbGFjZXMgdGhlIGRlcHJlY2F0ZWQgY2FsbHMK PiA+IHdoaWNoIGFsc28gc2ltcGxpZmllcyB0aGUgY29kZSBjb25zaWRlcmFibHkuCj4gCj4gCj4g VGhhbmtzIGZvciBwb3N0aW5nIHRoYXQhIEl0IGNlcnRhaW5seSBmaXhlcyB0aGF0IGlzc3VlLgoK QWNrZWQtYnk/Cgo+IEkgd2FzIHdvbmRlcmluZyBpZiB5b3UgaGFkIHNlZW4gdGhlc2UgYXMgd2Vs bDoKPiAKPiAvaG9tZS9rb25yYWQvcWVtdS10cmFkLmdpdC92bmMuYzoxOTI5OjE6IHdhcm5pbmc6 Cj4g4oCYZ251dGxzX2Fub25fc2VydmVyX2NyZWRlbnRpYWxz4oCZIGlzIGRlcHJlY2F0ZWQKPiBb LVdkZXByZWNhdGVkLWRlY2xhcmF0aW9uc10KPiAgewo+ICBeCj4gL2hvbWUva29ucmFkL3FlbXUt dHJhZC5naXQvdm5jLmM6IEluIGZ1bmN0aW9uCj4g4oCYdm5jX3Rsc19pbml0aWFsaXplX2Fub25f Y3JlZOKAmToKPiAvaG9tZS9rb25yYWQvcWVtdS10cmFkLmdpdC92bmMuYzoxOTMwOjU6IHdhcm5p bmc6Cj4g4oCYZ251dGxzX2Fub25fc2VydmVyX2NyZWRlbnRpYWxz4oCZIGlzIGRlcHJlY2F0ZWQK PiBbLVdkZXByZWNhdGVkLWRlY2xhcmF0aW9uc10KPiAgICAgIGdudXRsc19hbm9uX3NlcnZlcl9j cmVkZW50aWFscyBhbm9uX2NyZWQ7Cj4gICAgICBeCj4gL2hvbWUva29ucmFkL3FlbXUtdHJhZC5n aXQvdm5jLmM6IEluIGZ1bmN0aW9uIOKAmHZuY19zdGFydF90bHPigJk6Cj4gL2hvbWUva29ucmFk L3FlbXUtdHJhZC5naXQvdm5jLmM6MjIwMzo2OiB3YXJuaW5nOgo+IOKAmGdudXRsc19hbm9uX3Nl cnZlcl9jcmVkZW50aWFsc+KAmSBpcyBkZXByZWNhdGVkCj4gWy1XZGVwcmVjYXRlZC1kZWNsYXJh dGlvbnNdCj4gICAgICAgZ251dGxzX2Fub25fc2VydmVyX2NyZWRlbnRpYWxzIGFub25fY3JlZCA9 Cj4gdm5jX3Rsc19pbml0aWFsaXplX2Fub25fY3JlZCgpOwo+ICAgICAgIF4KPiA/Cj4gCj4gKFRo aXMgaXMgRmVkb3JhIDIzKQoKTm9wZS4KCiBMdWlzCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkNvY2NpIG1haWxpbmcgbGlzdApDb2NjaUBzeXN0ZW1lLmxp cDYuZnIKaHR0cHM6Ly9zeXN0ZW1lLmxpcDYuZnIvbWFpbG1hbi9saXN0aW5mby9jb2NjaQo=