From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1u1w-00065u-0V for qemu-devel@nongnu.org; Thu, 26 Nov 2015 05:44:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1u1u-0003i7-QI for qemu-devel@nongnu.org; Thu, 26 Nov 2015 05:43:59 -0500 Date: Thu, 26 Nov 2015 11:43:47 +0100 From: Kevin Wolf Message-ID: <20151126104347.GC4447@noname.redhat.com> References: <1447108773-6836-1-git-send-email-mreitz@redhat.com> <1447108773-6836-13-git-send-email-mreitz@redhat.com> <20151125155706.GE12581@noname.str.redhat.com> <5655DBD3.2020203@redhat.com> <20151125161843.GH12581@noname.str.redhat.com> <5655E11A.4050506@redhat.com> <20151126074815.GA22939@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gKMricLos+KVdGMg" Content-Disposition: inline In-Reply-To: <20151126074815.GA22939@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [PATCH v7 12/24] virtio-blk: Functions for op blocker management List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Alberto Garcia , qemu-block@nongnu.org, John Snow , Markus Armbruster , qemu-devel@nongnu.org, Paolo Bonzini , Max Reitz --gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 26.11.2015 um 08:48 hat Stefan Hajnoczi geschrieben: > On Wed, Nov 25, 2015 at 05:26:02PM +0100, Max Reitz wrote: > > On 25.11.2015 17:18, Kevin Wolf wrote: > > > Am 25.11.2015 um 17:03 hat Max Reitz geschrieben: > > >> On 25.11.2015 16:57, Kevin Wolf wrote: > > >>> Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: > > >>> This makes me wonder: What do we even block here any more? If I did= n't > > >>> miss anything, it's only BLOCK_OP_TYPE_BACKUP_TARGET, and I'm not s= ure > > >>> why this needs to be blocked, or if we simply forgot to enable it. > > >> > > >> Well, even though in practice this wall of code doesn't make much se= nse, > > >> of course it will be safe for potential additions of new op blockers. > > >> > > >> And of course we actually don't want these blockers at all anymore... > > >=20 > > > Yes, but dataplane shouldn't really be special enough any more that we > > > want to disable features for it initially. By now it sounds more like= an > > > easy way to forget unblocking a new feature even though it would work. > > >=20 > > > So perhaps we should really just remove the blockers from dataplane. > > > Then we don't have to answer the question above... > >=20 > > Well, maybe. I guess this is up to Stefan. >=20 > At this point blockdev.c and block jobs acquire/release AioContext, > hence all these op blockers are being unblocked. I think we can switch > from whitelisting (unblocking) nearly everything to blacklisting > (blocking) only things that aren't supported yet. As I said, there is only one operation that isn't whitelisted today, BLOCK_OP_TYPE_BACKUP_TARGET, and I would be surprised if it weren't just a bug that it's not whitelisted yet. Kevin --gKMricLos+KVdGMg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJWVuJjAAoJEH8JsnLIjy/WcEMQAKsvVPOo6CsypGnZbkYMtOqD S2lMDSQkD+CkDoyuOLqcmBxmNujbxbmSYIE2c0ENaVwFwSfJomP1OT2Gl0+ODhWi LGtCuMPbSqNyd4ntyiEZrOa5oGwC5e7opHAy5s+EZSYvYZMSz7YEQ7HVkfz9DD8Z yNF2Xl+mFbONapFIDKez+y9zWb+QcaIshalnEWjdaJSgRvSz4fnFVVdzixQeZtML zyr1vr/IJM9WRWRdnvDH5EtNGH7dBUxeJIRg42WRUGCvg0di1xR0vn78ZhyqVZLQ ++V8L9WLZwJUVqdnhOuaC+RzzpZODGF1UXbZt8U/GzB/oaD13tNvCWTch15er6f6 zXgGiRu6A9hGCFzIODTw41aXcvqJdCC5STJpP8rBzxcQDDMAa9m8BWxy+WZeI3Ek ibcRpKANT8Js18LMgdhTyDyDqe6kLOB/3GgNt+ZeDjTEUmZaeDqDNtBBzO08m2KC xMLZeow5/OiUrT6pUXwQ6z9boYBl3VnDyl6B5l7XHpF8BnMRFCxSLc8b0cyQLiBL fKFNM7IgWEi52/vpcX/VAOim/76KK5Aiv4l2UyijP2IVIrm+cM2GJ5dlBrVeFD4E gvHV1Vw9mTrsTZuuuF6jonyQ8KKPuQ9WMiQtfVdBN1FxhItiDGgHxLoASdpokEQz JvuJWBpiYoDH6fHtua6Z =CULS -----END PGP SIGNATURE----- --gKMricLos+KVdGMg--