From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754023AbbK0Hjk (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 Nov 2015 02:39:40 -0500
Received: from mail-wm0-f47.google.com ([74.125.82.47]:37267 "EHLO
	mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751304AbbK0Hjh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 Nov 2015 02:39:37 -0500
Date: Fri, 27 Nov 2015 08:39:32 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Seth Jennings <sjennings@variantweb.net>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Peter Anvin <hpa@zytor.com>, Daniel J Blueman <daniel@numascale.com>,
        Yinghai Lu <yinghai@kernel.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] x86: mm: clean up probe_memory_block_size()
Message-ID: <20151127073932.GB6234@gmail.com>
References: <1448591809-10369-1-git-send-email-sjennings@variantweb.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1448591809-10369-1-git-send-email-sjennings@variantweb.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Seth Jennings <sjennings@variantweb.net> wrote:

> v2:
> remove local bz variable (Ingo) and debug message since, if
> the 2GB message doesn't print, there is only one possible
> block size.

I'd not remove the info message, it would print the memory block size regardless 
of memory size. Yes, one could decode the 'no message' case as 'the kernel used 
the default value' - but that's very version dependent and obscure in any case. 
Please keep the debug message in both code paths, like the original code had it.

But, on a second thought, I'd definitely harmonize the messages, instead of:

>  		pr_info("Using 2GB memory block size for large-memory system\n");
> 	printk(KERN_DEBUG "memory block size : %ldMB\n", bz >> 20);

I'd print:

>  		pr_info("x86/mm: Memory block size: 2GB, large-memory system\n");
> 	pr_info("x86/mm: Memory block size: %ldMB\n", bz >> 20);

Also note how I changed both printouts to pr_info(), so that we have the memory 
block size information printed unconditionally.

(And btw., doing this printout means that we should keep the 'bz' local variable.)

Thanks,

	Ingo