From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED
Date: Fri, 27 Nov 2015 19:29:29 +0800 [thread overview]
Message-ID: <20151127112928.GC10191@pxdev.xzpeter.org> (raw)
In-Reply-To: <56582D47.6040905@redhat.com>
On Fri, Nov 27, 2015 at 11:15:35AM +0100, Paolo Bonzini wrote:
>
>
> On 27/11/2015 03:48, Peter Xu wrote:
> > +##
> > +# @DUMP_COMPLETED
> > +#
> > +# Emitted when background dump has completed
> > +#
> > +# Since: 2.6
> > +##
> > +{ 'event': 'DUMP_COMPLETED' ,
> > + 'data': { 'msg': 'str' } }
>
> This makes it hard to understand whether there was an error or not. I
> suggest using '*error': 'str' instead, and omitting the error if the
> dump is successful.
Will adopt it. Thanks!
Peter
>
> Paolo
next prev parent reply other threads:[~2015-11-27 11:29 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 2:48 [Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory Peter Xu
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 1/8] dump-guest-memory: cleanup: removing dump_{error|cleanup}() Peter Xu
2015-11-27 4:28 ` Fam Zheng
2015-11-27 6:51 ` Peter Xu
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces Peter Xu
2015-11-27 4:31 ` Fam Zheng
2015-11-27 6:05 ` Peter Xu
2015-11-30 18:21 ` Eric Blake
2015-12-01 1:28 ` Peter Xu
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support Peter Xu
2015-11-27 5:14 ` Fam Zheng
2015-11-27 5:20 ` Fam Zheng
2015-11-27 6:27 ` Peter Xu
2015-11-27 10:14 ` Paolo Bonzini
2015-11-27 11:03 ` Peter Xu
2015-11-28 5:51 ` Peter Xu
2015-11-30 1:48 ` Fam Zheng
2015-11-27 10:31 ` Paolo Bonzini
2015-11-27 11:26 ` Peter Xu
2015-11-27 11:52 ` Paolo Bonzini
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED Peter Xu
2015-11-27 5:19 ` Fam Zheng
2015-11-27 6:43 ` Peter Xu
2015-11-27 10:15 ` Paolo Bonzini
2015-11-27 11:29 ` Peter Xu [this message]
2015-11-30 18:18 ` Eric Blake
2015-12-01 1:52 ` Peter Xu
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status Peter Xu
2015-11-27 5:25 ` Fam Zheng
2015-11-27 7:03 ` Peter Xu
2015-11-27 10:17 ` Paolo Bonzini
2015-11-27 11:33 ` Peter Xu
2015-11-30 18:27 ` Eric Blake
2015-12-01 2:03 ` Peter Xu
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 6/8] dump-query: implement "status" of "dump-query" command Peter Xu
2015-11-27 10:22 ` Paolo Bonzini
2015-11-27 11:42 ` Peter Xu
2015-11-27 11:53 ` Paolo Bonzini
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 7/8] DumpState: adding total_size and written_size fields Peter Xu
2015-11-27 2:48 ` [Qemu-devel] [PATCH v2 8/8] dump-query: make the percentage accurate Peter Xu
2015-11-27 2:59 ` [Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory Peter Xu
2015-11-27 5:28 ` Fam Zheng
2015-11-27 6:53 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151127112928.GC10191@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.