From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jianbo Liu <jianbo.liu@linaro.org>
Subject: Re: [PATCH v3 2/2] config: disable
 CONFIG_RTE_SCHED_VECTOR for arm
Date: Sun, 29 Nov 2015 18:48:29 -0500
Message-ID: <20151129234829.GA2913@qq.com>
References: <1448631268-10692-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1448631268-10692-3-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 85DB45A9D
 for <dev@dpdk.org>; Sun, 29 Nov 2015 16:48:27 +0100 (CET)
Received: by wmuu63 with SMTP id u63so101804683wmu.0
 for <dev@dpdk.org>; Sun, 29 Nov 2015 07:48:27 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1448631268-10692-3-git-send-email-jerin.jacob@caviumnetworks.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Nov 27, 2015 at 07:04:28PM +0530, Jerin Jacob wrote:
> Commit 42ec27a0178a causes compiling error on arm, as RTE_SCHED_VECTOR
> does support only SSE intrinsic, so disable it till we have neon support.
> 
> Fixes: 42ec27a0178a ("sched: enable SSE optimizations in config")
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  config/common_arm64                      | 1 +
>  config/defconfig_arm-armv7a-linuxapp-gcc | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/config/common_arm64 b/config/common_arm64
> index 5e5e303..d6a9cb9 100644
> --- a/config/common_arm64
> +++ b/config/common_arm64
> @@ -46,3 +46,4 @@ CONFIG_RTE_LIBRTE_I40E_PMD=n
>  CONFIG_RTE_LIBRTE_LPM=n
>  CONFIG_RTE_LIBRTE_TABLE=n
>  CONFIG_RTE_LIBRTE_PIPELINE=n
> +CONFIG_RTE_SCHED_VECTOR=n
> diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_arm-armv7a-linuxapp-gcc
> index 82143af..9924ff9 100644
> --- a/config/defconfig_arm-armv7a-linuxapp-gcc
> +++ b/config/defconfig_arm-armv7a-linuxapp-gcc
> @@ -57,6 +57,7 @@ CONFIG_RTE_LIBRTE_ACL=n
>  CONFIG_RTE_LIBRTE_LPM=n
>  CONFIG_RTE_LIBRTE_TABLE=n
>  CONFIG_RTE_LIBRTE_PIPELINE=n
> +CONFIG_RTE_SCHED_VECTOR=n
>  
>  # cannot use those on ARM
>  CONFIG_RTE_KNI_KMOD=n
> -- 
> 2.1.0
> 

Hi Jerin,
In this way, we still have to modify two files each time a new feature
is added but not verified on ARM architectures.
Since disabling those drivers and libs are common for both armv7 and
armv8, can you put them in one config file, for example: common_arm? 
It is not like common_arm64, which is solely for armv8 platform.
Actually, the arm64 common config is defconfig_arm64-armv8a-linuxapp-gcc
you can include it in the thunderx or xgene1 config files respectively,
and overriding some special config if needed.

On the other hand, If we support the features in the future by
replacing SSE intrinsic with NEON, we just need to remove the lines in one place.

Regards,
Jianbo