From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46243)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a3Ehu-0005gu-I3
	for qemu-devel@nongnu.org; Sun, 29 Nov 2015 22:00:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a3Eht-00058K-Ly
	for qemu-devel@nongnu.org; Sun, 29 Nov 2015 22:00:50 -0500
Date: Mon, 30 Nov 2015 11:00:38 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20151130030038.GE10896@ad.usersys.redhat.com>
References: <1448388091-117282-1-git-send-email-pbonzini@redhat.com>
	<1448388091-117282-4-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1448388091-117282-4-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 03/40] virtio: move allocation to
 virtqueue_pop/vring_pop
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org

On Tue, 11/24 19:00, Paolo Bonzini wrote:
> @@ -436,10 +454,11 @@ static void control_out(VirtIODevice *vdev, VirtQueue *vq)
>              buf = g_malloc(cur_len);
>              len = cur_len;
>          }
> -        iov_to_buf(elem.out_sg, elem.out_num, 0, buf, cur_len);
> +        iov_to_buf(elem->out_sg, elem->out_num, 0, buf, cur_len);
>  
>          handle_control_message(vser, buf, cur_len);
> -        virtqueue_push(vq, &elem, 0);
> +        virtqueue_push(vq, elem, 0);
> +	g_free(elem);

s/^\t/        / ?