From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] i40evf: fix mac deletion when stop dev Date: Mon, 30 Nov 2015 08:33:00 -0800 Message-ID: <20151130083300.75ba06bc@xeon-e3> References: <1448855649-24658-1-git-send-email-jingjing.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Jingjing Wu Return-path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id ADDF469C8 for ; Mon, 30 Nov 2015 17:32:50 +0100 (CET) Received: by pabfh17 with SMTP id fh17so195174864pab.0 for ; Mon, 30 Nov 2015 08:32:50 -0800 (PST) In-Reply-To: <1448855649-24658-1-git-send-email-jingjing.wu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 30 Nov 2015 11:54:09 +0800 Jingjing Wu wrote: > + (void)rte_memcpy(mac_addr.addr_bytes, hw->mac.addr, > + sizeof(mac_addr.addr_bytes)) Please don't add useless (void) cast. I haven't seen that since lint on Unix.