From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3Lkp-0005Tt-QP for qemu-devel@nongnu.org; Mon, 30 Nov 2015 05:32:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3Lkm-0001Qn-LE for qemu-devel@nongnu.org; Mon, 30 Nov 2015 05:32:19 -0500 Date: Mon, 30 Nov 2015 11:32:04 +0100 From: Kevin Wolf Message-ID: <20151130103204.GC4494@noname.str.redhat.com> References: <1448294400-476-1-git-send-email-kwolf@redhat.com> <1448294400-476-21-git-send-email-kwolf@redhat.com> <5658C742.2090205@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JgQwtEuHJzHdouWu" Content-Disposition: inline In-Reply-To: <5658C742.2090205@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 20/21] qemu-iotests: Test cache mode option inheritance List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org --JgQwtEuHJzHdouWu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 27.11.2015 um 22:12 hat Max Reitz geschrieben: > On 23.11.2015 16:59, Kevin Wolf wrote: > > This is doing a more complete test on setting cache modes both while > > opening an image (i.e. in a -drive command line) and in reopen > > situations. It checks that reopen can specify options for child nodes > > and that cache modes are correctly inherited from parent nodes where > > they are not specified. > >=20 > > Signed-off-by: Kevin Wolf > > --- > > tests/qemu-iotests/142 | 354 ++++++++++++++++++++ > > tests/qemu-iotests/142.out | 788 +++++++++++++++++++++++++++++++++++++= ++++++++ > > tests/qemu-iotests/group | 1 + > > 3 files changed, 1143 insertions(+) > > create mode 100755 tests/qemu-iotests/142 > > create mode 100644 tests/qemu-iotests/142.out >=20 > Comments below, to make it short: With %s/bs->backing_hd/bs->backing/ > and a comment about why you commented 'out | grep "Cache"': Because I'm stupid. I'll fix that, thanks. Kevin --JgQwtEuHJzHdouWu Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJWXCWkAAoJEH8JsnLIjy/WJIEP/0IVxuljrKp81P0bDG116LGc AM7a2ppUe4fFHGf1+RAvlf+a5bjHJBFc+Ss/Xjr4Hf+9jPjzQaen2VIWMzAlYJjO AdYMFbNo6b2rG12m8TrQWoV/+/SCYHOvTujJ3Va+cQj55AB0gA//P05+57BxV+Uq +btRCPLKXkPKPTl4Vc0o8zDq3EPxRj75/zLWVi8tHN/OuFhyMwH6ZIM3fgG9LXXu AanavmqFwOl9DggOzywW/2ZuuhiK/Wdx4JRPV1B5BswflReEH4sZVrek+FA7jlC7 mmPL7o1Fs3kuIONzej3S/MxrcP4FpQKUQZABFJF5tBBzKoQ4kjzUoSj1/3lPDHya elt+e5MwEawtjlltjyfCiCagCMGHTYYDm3+X8VE+6yED73sXMApam3lO3RSb6Khi /qTvWR1f5dsb8wZGYbPgSeZMPx5Dt4OS1bZjQ+50A1WelQdca4PhASzFRp4wZkSp oUNGQ+6vq4bePkGbbxC4KUALPor0eWQ4bMSaW0R6FJj54cbV0jdJNpzg1spTjAmB Ttx5+fzejnDXkY7rZI9kfCsbc/jBHKm/lIqUXdDmaoqWs5Dv2ReoREFcQjv+FDLx NTv6vUfoROGsjKqKZiaD6rLwwC4j8SSdvgkpYhss3+X6nOcOH9A5euPVZOXpnWcw dz1HvEmUVC7wuDEYFt0X =/QFB -----END PGP SIGNATURE----- --JgQwtEuHJzHdouWu--