From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753769AbbK3MLM (ORCPT ); Mon, 30 Nov 2015 07:11:12 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54742 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753116AbbK3MLK (ORCPT ); Mon, 30 Nov 2015 07:11:10 -0500 Date: Mon, 30 Nov 2015 12:10:43 +0000 From: Mark Brown To: Simon Arlott Cc: devicetree@vger.kernel.org, Liam Girdwood , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org, Florian Fainelli , Jonas Gorski Message-ID: <20151130121043.GX1929@sirena.org.uk> References: <565A18DD.60108@simon.arlott.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HBXo5IaYAxUG7vuS" Content-Disposition: inline In-Reply-To: <565A18DD.60108@simon.arlott.org.uk> X-Cookie: A beer delayed is a beer denied. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] regulator: Add regmap support to regulator-fixed device tree binding X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HBXo5IaYAxUG7vuS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 28, 2015 at 09:13:01PM +0000, Simon Arlott wrote: > Add properties for regmap to the regulator-fixed device tree binding: > * Reference the regmap phandle > * Specify the enable offset and enable mask > * Reuse enable-active-high for regmap >=20 > This is required for Broadcom BCM63xx SoCs that enable power to > individual peripherals by clearing a bit in the miscIddqCtrl register. Just write a driver for this, the fixed driver is really intended for things like discrete regulators and if we were going to do a generic regmap driver (which I'm not terribly keen on as it means we're not able to later add additional information or custom handling in the driver) we should just do that rather than shoehorning things into the fixed driver. --HBXo5IaYAxUG7vuS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWXDzDAAoJECTWi3JdVIfQp5oH/jMvJGrqusp7GtHLhtpNoTqh GQvZqYxkcqogSvr2xt+Y6A1XOCYxocJ1k312TlNQx4foN51/kIdoeZxclFLLMxPn v9PXoLH3KkpgmS1Qb4KMFQJkrSaEL2+OWAyXF/afrPWzPCjvVPXwj4dzNPh5OqP7 oNJ6y+YHETlt5Z2gjofNqW1GCO5oLxXA/qZjDDGSaC7jCmOLu8w8gwg5dI6X9Wzh +sJwW2KVz9Cu0QtjP8vwwU1uaYEz/hEEWAOzWWXXPQfDg9rhKL/rzN7p9MuwDij6 1K0pfgMBrg0D83ovvYyaK/zBiJZFcDPggawoagc4O0jocCjIfkk8eHxBM+zO5Dk= =Z23Z -----END PGP SIGNATURE----- --HBXo5IaYAxUG7vuS-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/2] regulator: Add regmap support to regulator-fixed device tree binding Date: Mon, 30 Nov 2015 12:10:43 +0000 Message-ID: <20151130121043.GX1929@sirena.org.uk> References: <565A18DD.60108@simon.arlott.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HBXo5IaYAxUG7vuS" Return-path: Content-Disposition: inline In-Reply-To: <565A18DD.60108-qdVf85lJwsCyrPCCpiK2c/XRex20P6io@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Simon Arlott Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liam Girdwood , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Florian Fainelli , Jonas Gorski List-Id: devicetree@vger.kernel.org --HBXo5IaYAxUG7vuS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 28, 2015 at 09:13:01PM +0000, Simon Arlott wrote: > Add properties for regmap to the regulator-fixed device tree binding: > * Reference the regmap phandle > * Specify the enable offset and enable mask > * Reuse enable-active-high for regmap >=20 > This is required for Broadcom BCM63xx SoCs that enable power to > individual peripherals by clearing a bit in the miscIddqCtrl register. Just write a driver for this, the fixed driver is really intended for things like discrete regulators and if we were going to do a generic regmap driver (which I'm not terribly keen on as it means we're not able to later add additional information or custom handling in the driver) we should just do that rather than shoehorning things into the fixed driver. --HBXo5IaYAxUG7vuS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWXDzDAAoJECTWi3JdVIfQp5oH/jMvJGrqusp7GtHLhtpNoTqh GQvZqYxkcqogSvr2xt+Y6A1XOCYxocJ1k312TlNQx4foN51/kIdoeZxclFLLMxPn v9PXoLH3KkpgmS1Qb4KMFQJkrSaEL2+OWAyXF/afrPWzPCjvVPXwj4dzNPh5OqP7 oNJ6y+YHETlt5Z2gjofNqW1GCO5oLxXA/qZjDDGSaC7jCmOLu8w8gwg5dI6X9Wzh +sJwW2KVz9Cu0QtjP8vwwU1uaYEz/hEEWAOzWWXXPQfDg9rhKL/rzN7p9MuwDij6 1K0pfgMBrg0D83ovvYyaK/zBiJZFcDPggawoagc4O0jocCjIfkk8eHxBM+zO5Dk= =Z23Z -----END PGP SIGNATURE----- --HBXo5IaYAxUG7vuS-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html