Re: [PATCH phosphor-host-ipmid 1/3] ipmid: Use updated dbus HostIpmi interface

[Patrick Williams <patrick@stwcx.xyz>]

[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]

Chris,

Why does this patch exist with whitespace only changes?  Did something
go wrong in a rebase you did?

On Wed, Nov 25, 2015 at 02:20:22AM -0500, OpenBMC Patches wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
> 
> With the updated HostIpmi dbus interface, netfns are not packed with
> LUNs, and the CC is separate from the data.  This means we no longer
> have to define NETFN_* as arbitrarily shifted, and we have the added
> bonus of replying to messages where lun != 0.
> 
> We may want to separate the CC returned from the handlers in future too.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> ---
>  ipmid-api.h | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/ipmid-api.h b/ipmid-api.h
> index 2d58961..f9c03dd 100644
> --- a/ipmid-api.h
> +++ b/ipmid-api.h
> @@ -63,16 +63,16 @@ extern "C" void ipmi_register_callback(ipmi_netfn_t, ipmi_cmd_t,
>  // Note: these are also shifted left to make room for the LUN.
>  enum ipmi_net_fns
>  {
> -    NETFUN_CHASSIS   =   0x00,
> -    NETFUN_BRIDGE    =   0x02,
> -    NETFUN_SENSOR    =   0x04,
> -    NETFUN_APP       =   0x06,
> -    NETFUN_FIRMWARE  =   0x08,
> -    NETFUN_STORAGE   =   0x0a,
> -    NETFUN_TRANSPORT =   0x0c,
> -    NETFUN_GRPEXT    =   0x2c,
> -    NETFUN_NONE      =   0x30,
> -    NETFUN_OEM       =   0x32
> +    NETFUN_CHASSIS  =   0x00,
> +    NETFUN_BRIDGE   =   0x02,
> +    NETFUN_SENSOR   =   0x04,
> +    NETFUN_APP      =   0x06,
> +    NETFUN_FIRMWARE =   0x08,
> +    NETFUN_STORAGE  =   0x0a,
> +    NETFUN_TRANPORT =   0x0c,
> +    NETFUN_GRPEXT   =   0x2c,
> +    NETFUN_NONE     =   0x30,
> +    NETFUN_OEM      =   0x32
>  };
>  
>  // IPMI commands for net functions. Since this is to be used both by the ipmi
> -- 
> 2.6.3
> 
> 
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc

-- 
Patrick Williams

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]