From: Seth Jennings <sjennings@variantweb.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Peter Anvin <hpa@zytor.com>,
Daniel J Blueman <daniel@numascale.com>,
Yinghai Lu <yinghai@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] x86: mm: clean up probe_memory_block_size()
Date: Mon, 30 Nov 2015 10:48:17 -0600 [thread overview]
Message-ID: <20151130164817.GA18972@cerebellum.local.variantweb.net> (raw)
In-Reply-To: <20151127073932.GB6234@gmail.com>
On Fri, Nov 27, 2015 at 08:39:32AM +0100, Ingo Molnar wrote:
>
> * Seth Jennings <sjennings@variantweb.net> wrote:
>
> > v2:
> > remove local bz variable (Ingo) and debug message since, if
> > the 2GB message doesn't print, there is only one possible
> > block size.
>
> I'd not remove the info message, it would print the memory block size regardless
> of memory size. Yes, one could decode the 'no message' case as 'the kernel used
> the default value' - but that's very version dependent and obscure in any case.
> Please keep the debug message in both code paths, like the original code had it.
>
> But, on a second thought, I'd definitely harmonize the messages, instead of:
>
> > pr_info("Using 2GB memory block size for large-memory system\n");
> > printk(KERN_DEBUG "memory block size : %ldMB\n", bz >> 20);
>
> I'd print:
>
> > pr_info("x86/mm: Memory block size: 2GB, large-memory system\n");
> > pr_info("x86/mm: Memory block size: %ldMB\n", bz >> 20);
>
> Also note how I changed both printouts to pr_info(), so that we have the memory
> block size information printed unconditionally.
>
> (And btw., doing this printout means that we should keep the 'bz' local variable.)
Just sent out v3.
Thanks,
Seth
>
> Thanks,
>
> Ingo
prev parent reply other threads:[~2015-11-30 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 2:36 [PATCHv2] x86: mm: clean up probe_memory_block_size() Seth Jennings
2015-11-27 7:39 ` Ingo Molnar
2015-11-30 16:48 ` Seth Jennings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130164817.GA18972@cerebellum.local.variantweb.net \
--to=sjennings@variantweb.net \
--cc=daniel@numascale.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.