All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi
Subject: Re: [PATCH 1/4] drm/i915: Teach hangcheck about long operations on rings
Date: Mon, 30 Nov 2015 17:11:30 +0000	[thread overview]
Message-ID: <20151130171130.GD22663@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1448902389-12477-1-git-send-email-mika.kuoppala@intel.com>

On Mon, Nov 30, 2015 at 06:53:06PM +0200, Mika Kuoppala wrote:
> Some operations that happen in ringbuffer, like flushing,
> can take significant amounts of time. After some intense
> shader tests, the PIPE_CONTROL with flush can apparently last
> longer time than what is our hangcheck tick (1500ms). If
> this happens twice in a row, even with subsequent batches,
> the hangcheck score decaying mechanism can't cope and
> hang is declared.
> 
> Strip out actual head checking to a separate function and if
> actual head has not moved, check if it is lingering inside the
> ringbuffer as opposed to batch. If so, treat it as if it would be
> inside loop to only slightly increment the hangcheck score.

The PIPE_CONTROL in the ring after the batch, is equivalent to the batch
performing its own PIPE_CONTROL as the last instruction. It does not
make sense to distinguish the two.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-11-30 17:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 16:53 [PATCH 1/4] drm/i915: Teach hangcheck about long operations on rings Mika Kuoppala
2015-11-30 16:53 ` [PATCH 2/4] drm/i915: Let hangcheck score decay faster than loop increment Mika Kuoppala
2015-11-30 17:18   ` Chris Wilson
2015-12-01  8:55     ` Daniel Vetter
2015-12-01 12:09     ` Mika Kuoppala
2015-11-30 16:53 ` [PATCH 3/4] drm/i915: Clear hangcheck score if engine is idle Mika Kuoppala
2015-11-30 17:10   ` Chris Wilson
2015-11-30 16:53 ` [PATCH 4/4] drm/i915: Detect small loops in hangcheck Mika Kuoppala
2015-11-30 17:11 ` Chris Wilson [this message]
2015-11-30 18:04   ` [PATCH 1/4] drm/i915: Teach hangcheck about long operations on rings Dave Gordon
2015-11-30 18:46     ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151130171130.GD22663@nuc-i3427.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kuoppala@linux.intel.com \
    --cc=miku@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.