From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754863AbbK3VPs (ORCPT ); Mon, 30 Nov 2015 16:15:48 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:59901 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754621AbbK3VPo (ORCPT ); Mon, 30 Nov 2015 16:15:44 -0500 Date: Mon, 30 Nov 2015 13:15:42 -0800 From: Darren Hart To: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Matthew Garrett , Pali =?iso-8859-1?Q?Roh=E1r?= , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing Message-ID: <20151130211542.GE30553@malice.jf.intel.com> References: <1f6ac54784b39ebb6ce02a9fb9e944c840fddb7b.1448547341.git.kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1f6ac54784b39ebb6ce02a9fb9e944c840fddb7b.1448547341.git.kernel@kempniu.pl> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2015 at 03:18:32PM +0100, Michał Kępień wrote: > On some laptop models (e.g. Dell Vostro V131), pressing the Dell Instant > Launch hotkey does not raise an i8042 interrupt - only WMI event 0xe025 > is generated. As there is no flawless way to determine whether a given > machine is capable of simulating a keypress when this hotkey is pressed, > a new module parameter is added so that the user can decide whether the > WMI event should be processed or ignored. > > Signed-off-by: Michał Kępień Module parameters are to be avoided wherever possible, especially for things like this which set precedent and don't scale well. If we cannot detect which machines use the EC and which only use WMI, then we can fall back to checking DMI for specific models. Per the above, and Pali's feedback. I'll be dropping this one in anticipation of a V2. Thanks, -- Darren Hart Intel Open Source Technology Center