From: kbuild test robot <lkp@intel.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: kbuild-all@01.org, daniel@quora.org, linux-usb@vger.kernel.org,
stern@rowland.harvard.edu, linux-kernel@vger.kernel.org,
Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: Re: [TESTPATCH] xhci: fix usb2 resume timing and races.
Date: Mon, 30 Nov 2015 23:59:38 +0800 [thread overview]
Message-ID: <201511302311.WKa4vSE1%fengguang.wu@intel.com> (raw)
In-Reply-To: <1448896592-26421-1-git-send-email-mathias.nyman@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1998 bytes --]
Hi Mathias,
[auto build test WARNING on: v4.4-rc1]
[cannot apply to: v4.4-rc3 v4.4-rc2 next-20151127]
url: https://github.com/0day-ci/linux/commits/Mathias-Nyman/xhci-fix-usb2-resume-timing-and-races/20151130-231438
config: i386-randconfig-r0-201548 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/usb/host/xhci-hub.c: In function 'xhci_get_port_status':
>> drivers/usb/host/xhci-hub.c:812:52: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
(raw_port_status & PORT_PLS_MASK) != XDEV_U3 &&
^
vim +812 drivers/usb/host/xhci-hub.c
796 bus_state->suspended_ports &= ~(1 << wIndex);
797 } else {
798 /*
799 * The resume has been signaling for less than
800 * 20ms. Report the port status as SUSPEND,
801 * let the usbcore check port status again
802 * and clear resume signaling later.
803 */
804 status |= USB_PORT_STAT_SUSPEND;
805 }
806 }
807 /* Clear stale usb2 resume signalling variables in case port changed
808 * state during 20ms resume signalling. For example on error
809 */
810 if ((bus_state->resume_done[wIndex] ||
811 test_bit(wIndex, &bus_state->resuming_ports) &&
> 812 (raw_port_status & PORT_PLS_MASK) != XDEV_U3 &&
813 (raw_port_status & PORT_PLS_MASK) != XDEV_RESUME)) {
814 bus_state->resume_done[wIndex] = 0;
815 clear_bit(wIndex, &bus_state->resuming_ports);
816 }
817 if ((raw_port_status & PORT_PLS_MASK) == XDEV_U0
818 && (raw_port_status & PORT_POWER)
819 && (bus_state->suspended_ports & (1 << wIndex))) {
820 bus_state->suspended_ports &= ~(1 << wIndex);
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 23433 bytes --]
next prev parent reply other threads:[~2015-11-30 16:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAMVG2sus03xnbCSikFGG+t2fXM_gME_jMeGpGHxVuVRks07WCg@mail.gmail.com>
2015-11-30 15:16 ` [TESTPATCH] xhci: fix usb2 resume timing and races Mathias Nyman
2015-11-30 15:59 ` kbuild test robot [this message]
2015-12-01 15:47 ` Alan Stern
2015-12-02 8:50 ` Mathias Nyman
2015-12-01 8:26 ` [TESTPATCH v2] " Mathias Nyman
2015-12-01 14:32 ` Felipe Balbi
2015-12-01 15:08 ` Mathias Nyman
2015-12-01 15:11 ` Felipe Balbi
2015-12-05 4:02 ` Daniel J Blueman
2015-12-08 11:16 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201511302311.WKa4vSE1%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=daniel@quora.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.