From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755607AbbLAIrs (ORCPT ); Tue, 1 Dec 2015 03:47:48 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:36351 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755471AbbLAIrr (ORCPT ); Tue, 1 Dec 2015 03:47:47 -0500 Date: Tue, 1 Dec 2015 09:47:42 +0100 From: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= To: Darren Hart Cc: Matthew Garrett , Pali =?utf-8?B?Um9ow6Fy?= , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing Message-ID: <20151201084742.GA6263@eudyptula.hq.kempniu.pl> References: <1f6ac54784b39ebb6ce02a9fb9e944c840fddb7b.1448547341.git.kernel@kempniu.pl> <20151130211542.GE30553@malice.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151130211542.GE30553@malice.jf.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Module parameters are to be avoided wherever possible, especially for things > like this which set precedent and don't scale well. If we cannot detect which > machines use the EC and which only use WMI, then we can fall back to checking > DMI for specific models. > > Per the above, and Pali's feedback. I'll be dropping this one in anticipation of > a V2. Thanks for reviewing, I'll prepare version 2 using DMI matching. -- Best regards, Michał Kępień