From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Viktorin Subject: Re: [PATCH 1/4] eal/arm: use RTE_ARM_EAL_RDTSC_USE_PMU in rte_cycle_32.h Date: Tue, 1 Dec 2015 13:41:07 +0100 Message-ID: <20151201134107.37a86077@pcviktorin.fit.vutbr.cz> References: <1448995276-9599-1-git-send-email-jianbo.liu@linaro.org> <1448995276-9599-2-git-send-email-jianbo.liu@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Jianbo Liu Return-path: Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16]) by dpdk.org (Postfix) with ESMTP id 4A9B858DB for ; Tue, 1 Dec 2015 13:43:46 +0100 (CET) In-Reply-To: <1448995276-9599-2-git-send-email-jianbo.liu@linaro.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Jianbo, thank you for this fix. I had the feeling this works the same like in the Linux Kernel where the CONFIG_ prefix is be used. My bad. I recommend to make this patch separate. I can't see any relation to the rest of the series. Regards Jan On Tue, 1 Dec 2015 13:41:13 -0500 Jianbo Liu wrote: > CONFIG_* from config files can not be used in code. > > Signed-off-by: Jianbo Liu > --- > lib/librte_eal/common/include/arch/arm/rte_cycles_32.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/include/arch/arm/rte_cycles_32.h b/lib/librte_eal/common/include/arch/arm/rte_cycles_32.h > index 6c6098e..9c1be71 100644 > --- a/lib/librte_eal/common/include/arch/arm/rte_cycles_32.h > +++ b/lib/librte_eal/common/include/arch/arm/rte_cycles_32.h > @@ -54,7 +54,7 @@ extern "C" { > * @return > * The time base for this lcore. > */ > -#ifndef CONFIG_RTE_ARM_EAL_RDTSC_USE_PMU > +#ifndef RTE_ARM_EAL_RDTSC_USE_PMU > > /** > * This call is easily portable to any ARM architecture, however, -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic