From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: dvyukov@google.com, vyasevich@gmail.com, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
edumazet@google.com, wdauchy@gmail.com,
rweikusat@mobileactivedefense.com, syzkaller@googlegroups.com,
kcc@google.com, glider@google.com, sasha.levin@oracle.com
Subject: Re: [PATCH net] ipv6: add complete rcu protection around np->opt
Date: Wed, 02 Dec 2015 23:38:21 -0500 (EST) [thread overview]
Message-ID: <20151202.233821.139368757119113563.davem@davemloft.net> (raw)
In-Reply-To: <1448854677.24696.117.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 29 Nov 2015 19:37:57 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> This patch addresses multiple problems :
>
> UDP/RAW sendmsg() need to get a stable struct ipv6_txoptions
> while socket is not locked : Other threads can change np->opt
> concurrently. Dmitry posted a syzkaller
> (http://github.com/google/syzkaller) program desmonstrating
> use-after-free.
>
> Starting with TCP/DCCP lockless listeners, tcp_v6_syn_recv_sock()
> and dccp_v6_request_recv_sock() also need to use RCU protection
> to dereference np->opt once (before calling ipv6_dup_options())
>
> This patch adds full RCU protection to np->opt
>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable.
next prev parent reply other threads:[~2015-12-03 4:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 11:00 use-after-free in ip6_setup_cork Dmitry Vyukov
2015-11-28 17:11 ` Eric Dumazet
2015-11-28 17:23 ` Eric Dumazet
2015-11-30 3:29 ` Eric Dumazet
2015-11-30 16:35 ` [PATCH net] ipv6: kill sk_dst_lock Eric Dumazet
2015-11-30 18:13 ` Paolo Abeni
2015-11-30 18:27 ` Eric Dumazet
2015-12-01 1:44 ` YOSHIFUJI Hideaki
2015-12-01 2:01 ` Eric Dumazet
2015-12-03 4:42 ` David Miller
2015-12-03 5:53 ` [PATCH v2 " Eric Dumazet
2015-12-03 16:32 ` David Miller
2015-12-03 16:49 ` Eric Dumazet
2015-12-03 16:49 ` Eric Dumazet
2015-12-03 5:57 ` [PATCH " Eric Dumazet
2015-11-30 3:37 ` [PATCH net] ipv6: add complete rcu protection around np->opt Eric Dumazet
2015-12-01 11:11 ` Hannes Frederic Sowa
2015-12-01 13:05 ` Eric Dumazet
2015-12-01 13:13 ` Hannes Frederic Sowa
2015-12-03 4:38 ` David Miller [this message]
2015-12-03 5:35 ` Eric Dumazet
2015-12-03 5:48 ` [PATCH net] ipv6: sctp: add " Eric Dumazet
2015-12-03 16:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202.233821.139368757119113563.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=glider@google.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kcc@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rweikusat@mobileactivedefense.com \
--cc=sasha.levin@oracle.com \
--cc=syzkaller@googlegroups.com \
--cc=vyasevich@gmail.com \
--cc=wdauchy@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.