From: Steven Rostedt <rostedt@goodmis.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] ftrace: Remove use of control list and ops
Date: Wed, 2 Dec 2015 09:15:33 -0500 [thread overview]
Message-ID: <20151202091533.1eea65cf@gandalf.local.home> (raw)
In-Reply-To: <20151202075911.GA26308@krava.brq.redhat.com>
On Wed, 2 Dec 2015 08:59:11 +0100
Jiri Olsa <jolsa@redhat.com> wrote:
> > - op->func(ip, parent_ip, op, regs);
> > + preempt_disable_notrace();
>
> I was wondering about not disabling preemption in the original
> ftrace_ops_recurs_func function.. thats why I added new one ;-)
Yeah, I paused on that too. But then I realized that pretty much all
callers of function tracing disable preemption too, so it shouldn't
cause really any more overhead.
-- Steve
next prev parent reply other threads:[~2015-12-02 14:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 22:36 [PATCH] ftrace: Remove use of control list and ops Steven Rostedt
2015-12-01 13:42 ` Jiri Olsa
2015-12-01 14:55 ` Steven Rostedt
2015-12-01 15:57 ` Jiri Olsa
2015-12-01 16:56 ` Steven Rostedt
2015-12-02 7:59 ` Jiri Olsa
2015-12-02 14:15 ` Steven Rostedt [this message]
2015-12-02 8:58 ` Jiri Olsa
2015-12-02 14:27 ` Steven Rostedt
2015-12-02 14:50 ` Jiri Olsa
2015-12-02 15:03 ` Steven Rostedt
2015-12-02 15:23 ` Jiri Olsa
2015-12-18 10:18 ` Jiri Olsa
2015-12-18 14:35 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202091533.1eea65cf@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.