From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760453AbbLCOmH (ORCPT ); Thu, 3 Dec 2015 09:42:07 -0500 Received: from down.free-electrons.com ([37.187.137.238]:37789 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760422AbbLCOmF (ORCPT ); Thu, 3 Dec 2015 09:42:05 -0500 Date: Thu, 3 Dec 2015 15:42:03 +0100 From: Alexandre Belloni To: Julius Werner Cc: Andrew Morton , Alessandro Zummo , Doug Anderson , Sonny Rao , Chris Zhong , Heiko Stuebner , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [rtc-linux] [PATCH] RTC: RK808: Work around hardware bug on November 31st Message-ID: <20151203144203.GA3515@piout.net> References: <1449107584-3192-1-git-send-email-jwerner@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449107584-3192-1-git-send-email-jwerner@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I would have liked to be in copy of that mail. Maybe you used get_maintainers on an old tree? On 02/12/2015 at 17:53:04 -0800, Julius Werner wrote : > In Fuzhou, China, the month of November seems to be having 31 days. > That's nice and all (I'm sure you can get a lot more done in a year that > way), but back here in other parts of the world we are not so lucky. > Therefore, if we read that date from the RTC we should correct it to > December 1st. > Wow, nice one... I hope reading the time properly fails thanks to the rtc_valid_tm(tm) in __rtc_read_time(). > This is not a full workaround. Since the RTC actually ticks all the way > through that imaginary day, there's no easy way to detect and correct > this issue if the device was offline the whole time and allowed it to > tick through to December 1st on the Rockchip calendar (which would be > December 2nd on the Gregorian one). Those edge cases can only really be > solved by regularly syncing to an external time source (e.g. NTP). > It will also happen if nobody reads the RTC time for that day (highly improbable in a default configuration). Do you need that patch for 4.4 or can it wait 4.5? > Signed-off-by: Julius Werner > Reviewed-by: Chris Zhong > --- > drivers/rtc/rtc-rk808.c | 93 ++++++++++++++++++++++++++----------------------- > 1 file changed, 50 insertions(+), 43 deletions(-) > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id i77si246251wmf.1.2015.12.03.06.42.04 for ; Thu, 03 Dec 2015 06:42:04 -0800 (PST) Date: Thu, 3 Dec 2015 15:42:03 +0100 From: Alexandre Belloni To: Julius Werner Cc: Andrew Morton , Alessandro Zummo , Doug Anderson , Sonny Rao , Chris Zhong , Heiko Stuebner , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [rtc-linux] [PATCH] RTC: RK808: Work around hardware bug on November 31st Message-ID: <20151203144203.GA3515@piout.net> References: <1449107584-3192-1-git-send-email-jwerner@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1449107584-3192-1-git-send-email-jwerner@chromium.org> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi, I would have liked to be in copy of that mail. Maybe you used get_maintainers on an old tree? On 02/12/2015 at 17:53:04 -0800, Julius Werner wrote : > In Fuzhou, China, the month of November seems to be having 31 days. > That's nice and all (I'm sure you can get a lot more done in a year that > way), but back here in other parts of the world we are not so lucky. > Therefore, if we read that date from the RTC we should correct it to > December 1st. > Wow, nice one... I hope reading the time properly fails thanks to the rtc_valid_tm(tm) in __rtc_read_time(). > This is not a full workaround. Since the RTC actually ticks all the way > through that imaginary day, there's no easy way to detect and correct > this issue if the device was offline the whole time and allowed it to > tick through to December 1st on the Rockchip calendar (which would be > December 2nd on the Gregorian one). Those edge cases can only really be > solved by regularly syncing to an external time source (e.g. NTP). > It will also happen if nobody reads the RTC time for that day (highly improbable in a default configuration). Do you need that patch for 4.4 or can it wait 4.5? > Signed-off-by: Julius Werner > Reviewed-by: Chris Zhong > --- > drivers/rtc/rtc-rk808.c | 93 ++++++++++++++++++++++++++----------------------- > 1 file changed, 50 insertions(+), 43 deletions(-) > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.