diff for duplicates of <20151203192750.GA19242@cmpxchg.org>
diff --git a/a/1.txt b/N1/1.txt
index 7a289bb..5dd558d 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -8,39 +8,4 @@ On Thu, Dec 03, 2015 at 05:27:18PM +0100, Michal Hocko wrote:
> instead...
You asked the same thing when reviewing the patch for the first
-time. :-) I think it's time to add a comment.
-
->From e8ba3f31bb43ed4091b997b6ee8857dc8bbcd349 Mon Sep 17 00:00:00 2001
-From: Johannes Weiner <hannes@cmpxchg.org>
-Date: Thu, 3 Dec 2015 14:21:45 -0500
-Subject: [PATCH] mm: memcontrol: clarify the uncharge_list() loop
-
-uncharge_list() does an unusual list walk because the function can
-take regular lists with dedicated list_heads as well as singleton
-lists where a single page is passed via its page->lru list node.
-
-This can sometimes lead to confusion, as well as suggestions to
-replace the loop with a list_for_each_entry(), which wouldn't work.
-
-Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
----
- mm/memcontrol.c | 4 ++++
- 1 file changed, 4 insertions(+)
-
-diff --git a/mm/memcontrol.c b/mm/memcontrol.c
-index 9acfb16..f7ee1c0 100644
---- a/mm/memcontrol.c
-+++ b/mm/memcontrol.c
-@@ -5422,6 +5422,10 @@ static void uncharge_list(struct list_head *page_list)
- struct list_head *next;
- struct page *page;
-
-+ /*
-+ * Note that the list can be a single page->lru; hence the
-+ * do-while loop instead of a simple list_for_each_entry().
-+ */
- next = page_list->next;
- do {
- unsigned int nr_pages = 1;
---
-2.6.3
\ No newline at end of file
+time. :-) I think it's time to add a comment.
\ No newline at end of file
diff --git a/a/content_digest b/N1/content_digest
index de8dd07..531e68e 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -39,42 +39,7 @@
"> instead...\n",
"\n",
"You asked the same thing when reviewing the patch for the first\n",
- "time. :-) I think it's time to add a comment.\n",
- "\n",
- ">From e8ba3f31bb43ed4091b997b6ee8857dc8bbcd349 Mon Sep 17 00:00:00 2001\n",
- "From: Johannes Weiner <hannes\@cmpxchg.org>\n",
- "Date: Thu, 3 Dec 2015 14:21:45 -0500\n",
- "Subject: [PATCH] mm: memcontrol: clarify the uncharge_list() loop\n",
- "\n",
- "uncharge_list() does an unusual list walk because the function can\n",
- "take regular lists with dedicated list_heads as well as singleton\n",
- "lists where a single page is passed via its page->lru list node.\n",
- "\n",
- "This can sometimes lead to confusion, as well as suggestions to\n",
- "replace the loop with a list_for_each_entry(), which wouldn't work.\n",
- "\n",
- "Signed-off-by: Johannes Weiner <hannes\@cmpxchg.org>\n",
- "---\n",
- " mm/memcontrol.c | 4 ++++\n",
- " 1 file changed, 4 insertions(+)\n",
- "\n",
- "diff --git a/mm/memcontrol.c b/mm/memcontrol.c\n",
- "index 9acfb16..f7ee1c0 100644\n",
- "--- a/mm/memcontrol.c\n",
- "+++ b/mm/memcontrol.c\n",
- "\@\@ -5422,6 +5422,10 \@\@ static void uncharge_list(struct list_head *page_list)\n",
- " \tstruct list_head *next;\n",
- " \tstruct page *page;\n",
- " \n",
- "+\t/*\n",
- "+\t * Note that the list can be a single page->lru; hence the\n",
- "+\t * do-while loop instead of a simple list_for_each_entry().\n",
- "+\t */\n",
- " \tnext = page_list->next;\n",
- " \tdo {\n",
- " \t\tunsigned int nr_pages = 1;\n",
- "-- \n",
- "2.6.3"
+ "time. :-) I think it's time to add a comment."
]
-6e503c0c57af01da1be8ea3b5fe99e29bd2e145781b4d3140a7fc4d7f88bb4b4
+2eecc3c1789e38e263d4f8ad8091dc57eb013f773504b2a0f53cd3d30f68a79c
diff --git a/a/1.txt b/N2/1.txt
index 7a289bb..a1685af 100644
--- a/a/1.txt
+++ b/N2/1.txt
@@ -10,7 +10,7 @@ On Thu, Dec 03, 2015 at 05:27:18PM +0100, Michal Hocko wrote:
You asked the same thing when reviewing the patch for the first
time. :-) I think it's time to add a comment.
->From e8ba3f31bb43ed4091b997b6ee8857dc8bbcd349 Mon Sep 17 00:00:00 2001
+From e8ba3f31bb43ed4091b997b6ee8857dc8bbcd349 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <hannes@cmpxchg.org>
Date: Thu, 3 Dec 2015 14:21:45 -0500
Subject: [PATCH] mm: memcontrol: clarify the uncharge_list() loop
diff --git a/a/content_digest b/N2/content_digest
index de8dd07..62d1cae 100644
--- a/a/content_digest
+++ b/N2/content_digest
@@ -41,7 +41,7 @@
"You asked the same thing when reviewing the patch for the first\n",
"time. :-) I think it's time to add a comment.\n",
"\n",
- ">From e8ba3f31bb43ed4091b997b6ee8857dc8bbcd349 Mon Sep 17 00:00:00 2001\n",
+ "From e8ba3f31bb43ed4091b997b6ee8857dc8bbcd349 Mon Sep 17 00:00:00 2001\n",
"From: Johannes Weiner <hannes\@cmpxchg.org>\n",
"Date: Thu, 3 Dec 2015 14:21:45 -0500\n",
"Subject: [PATCH] mm: memcontrol: clarify the uncharge_list() loop\n",
@@ -77,4 +77,4 @@
"2.6.3"
]
-6e503c0c57af01da1be8ea3b5fe99e29bd2e145781b4d3140a7fc4d7f88bb4b4
+c8e5b00eecedec89141c16c9322f8d656a182852a9bfa3005abc7741b38305c1
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.