From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4dom-0001jA-02 for qemu-devel@nongnu.org; Thu, 03 Dec 2015 19:01:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4doh-0000jr-VU for qemu-devel@nongnu.org; Thu, 03 Dec 2015 19:01:43 -0500 Date: Fri, 4 Dec 2015 10:55:03 +1100 From: David Gibson Message-ID: <20151203235503.GD9559@voom.redhat.com> References: <1449160660-3777-1-git-send-email-armbru@redhat.com> <1449160660-3777-4-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kvUQC+jR9YzypDnK" Content-Disposition: inline In-Reply-To: <1449160660-3777-4-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter.maydell@linaro.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de --kvUQC+jR9YzypDnK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 03, 2015 at 05:37:40PM +0100, Markus Armbruster wrote: > It should only be created via spapr_dr_connector_new(). Attempting to > create it with -device crashes. >=20 > Signed-off-by: Markus Armbruster Acked-by: David Gibson > --- > hw/ppc/spapr_drc.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c > index dad157f..8be62c3 100644 > --- a/hw/ppc/spapr_drc.c > +++ b/hw/ppc/spapr_drc.c > @@ -599,6 +599,10 @@ static void spapr_dr_connector_class_init(ObjectClas= s *k, void *data) > drck->attach =3D attach; > drck->detach =3D detach; > drck->release_pending =3D release_pending; > + /* > + * Reason: it crashes FIXME find and document the real reason > + */ > + dk->cannot_instantiate_with_device_add_yet =3D true; > } > =20 > static const TypeInfo spapr_dr_connector_info =3D { --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --kvUQC+jR9YzypDnK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWYNZXAAoJEGw4ysog2bOSlF0QALkd3FwZ/37ZUWOOGWkofaZi zn7zWToW/SkiPKrtsYww82zEH9PErcb3kQnsaHhSqh6X7VTyBp5F47cVEoD4oAnH Ha5F91GKLuCyvdRDXlgaxJzy9C/SYg6QPf6EP7axn6te1wjIh+1sU439dmLQF6H7 L0BOpJePzW1z05xwT5LB0KCR90B3rmpnTLP05T3GeNLWGe8COPJ8WGvw4/VQWP6a JSR4soo1k6QvDtiV9q071OuY+VoW5UGwsrH70OTW/N1oP3/KWkF27eT06P/NLeRm c0ltBGjzRT+aogf7BBZ1ade1wMo55bSIq9CkrsYYm08wXBuhdCMZux3opLYNLNUi slSlmdvow2AcsOozNXtQWCvr7aNIetZmPewdhvFYgto8p4tIktp0igTKvCfBoTbe +S8nqsbQZj/jIewFpqoHJY0AlctEfuqFGXo8i8xtmKIxtROxNhoVL23hfdC/rb/K S1+hU5vX82D60G8/FkQtUM50HYJc/H/1FSumPtZ82BAuLIQQDjrYU5lmEPypvrOL IYxXdgwuY7UmPtDh/qDLUuVKz/BQufxRW4aos3hVe0npvVFiBUaPntpIAz1HD2/a fBDnDLf/6zc9EfHTRchaYKdVxwxCe8nBMdUDF8eBldbK5P375adV8G4c9qv29ZHi g/KamZsc7v3dcAX333Jn =nCho -----END PGP SIGNATURE----- --kvUQC+jR9YzypDnK--