From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4lr3-00087X-3c for qemu-devel@nongnu.org; Fri, 04 Dec 2015 03:36:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4lr2-00021C-0l for qemu-devel@nongnu.org; Fri, 04 Dec 2015 03:36:37 -0500 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:56400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4lr1-00020p-RP for qemu-devel@nongnu.org; Fri, 04 Dec 2015 03:36:35 -0500 Date: Fri, 4 Dec 2015 09:36:33 +0100 From: Aurelien Jarno Message-ID: <20151204083633.GA13034@aurel32.net> References: <1448986767-28016-1-git-send-email-rth@twiddle.net> <20151201163254.GB9577@aurel32.net> <565F3A43.9030005@twiddle.net> <20151203121955.GA3108@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151203121955.GA3108@aurel32.net> Subject: Re: [Qemu-devel] [PATCH for-2.5] tcg: Increase the highwater reservation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On 2015-12-03 13:19, Aurelien Jarno wrote: > On 2015-12-02 10:36, Richard Henderson wrote: > > On 12/01/2015 08:32 AM, Aurelien Jarno wrote: > > >On 2015-12-01 08:19, Richard Henderson wrote: > > >>If there are a lot of guest memory ops in the TB, the amount of > > >>code generated by tcg_out_tb_finalize could be well more than 1k. > > >>In the short term, increase the reservation larger than any TB > > >>seen in practice. > > >> > > >>Reported-by: Aurelien Jarno > > >>Signed-off-by: Richard Henderson > > > > > >Thanks! I was testing the same patch locally after our discussion, and I > > >confirm it fixes the issue. > > > > Here's the proper patch for 2.6. If you'd like to run it through your same > > tests, please? > > The patch looks fine to me, the only tiny nitpick I have is that you can > return a bool instead of a hint. > > I am currently testing it (which is basically running a glibc build and > testsuite multiple time in a VM), I'll let you know the result by > tomorrow. In the meantime, you can add: > > Reviewed-by: Aurelien Jarno I haven't seen any crash so far, which is more time than it usually needs to trigger the issue. So I guess we can consider that the patch is correct. Therefore: Tested-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net