From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755747AbbLDJBx (ORCPT ); Fri, 4 Dec 2015 04:01:53 -0500 Received: from verein.lst.de ([213.95.11.211]:38248 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754335AbbLDJBw (ORCPT ); Fri, 4 Dec 2015 04:01:52 -0500 Date: Fri, 4 Dec 2015 10:01:50 +0100 From: Torsten Duwe To: Petr Mladek Cc: Steven Rostedt , Michael Ellerman , Jiri Kosina , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH v4 4/9] ppc64 ftrace_with_regs configuration variables Message-ID: <20151204090150.GA2861@lst.de> References: <20151125172608.9588569260@newverein.lst.de> <20151125172916.9D50269260@newverein.lst.de> <20151203162008.GF8047@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151203162008.GF8047@pathway.suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 03, 2015 at 05:20:08PM +0100, Petr Mladek wrote: > > IMHO, we should not define CC_USING_MPROFILE_KERNEL if it is not > supported by the compiler. Yes, true. > I took inspiration from the CC_USING_FENTRY handling in > linux/Makefile. The following code worked for me: > > CC_USING_MPROFILE_KERNEL := $(call cc-option, -pg -mprofile-kernel -DCC_USING_MPROFILE_KERNEL) > CC_FLAGS_FTRACE := $(CC_USING_MPROFILE_KERNEL) > KBUILD_CPPFLAGS += $(CC_USING_MPROFILE_KERNEL) Excellent! > I just do not understand why we need to add the flags also > to KBUILD_CPPFLAGS. It seems that they are duplicated > when compiling kernel/livepatch/core.o. But livepatching > did not work without it. I wonder if you found the culprit. Some assembler-with-cpp files also need to be notified? My plan is to first get this working reliably and then fine tune. Torsten