From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755823AbbLDJG1 (ORCPT ); Fri, 4 Dec 2015 04:06:27 -0500 Received: from verein.lst.de ([213.95.11.211]:38262 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754335AbbLDJGW (ORCPT ); Fri, 4 Dec 2015 04:06:22 -0500 Date: Fri, 4 Dec 2015 10:06:20 +0100 From: Torsten Duwe To: Petr Mladek Cc: Steven Rostedt , Michael Ellerman , Jiri Kosina , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH v4 8/9] Implement kernel live patching for ppc64le (ABIv2) Message-ID: <20151204090620.GB2861@lst.de> References: <20151125172608.9588569260@newverein.lst.de> <20151125172937.9425E69260@newverein.lst.de> <20151203162445.GG8047@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151203162445.GG8047@pathway.suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 03, 2015 at 05:24:45PM +0100, Petr Mladek wrote: > > +++ b/arch/powerpc/include/asm/livepatch.h > > @@ -0,0 +1,45 @@ > [...] > > +#include > > +#include > > + > > +#ifdef CONFIG_LIVEPATCH > > +static inline int klp_check_compiler_support(void) > > +{ > > +#if !defined(_CALL_ELF) || _CALL_ELF != 2 > > I am just curious why we do not check CC_USING_MPROFILE_KERNEL > like in the other similar locations. It would look less cryptic. > But I am not sure if it is precise enough. Because a ppc with a gcc > 4.8.5 is not sufficient. The code currently only works for the PPC ELF ABI v2, a.k.a. ppc64le. But now that you say it, CC_USING_MPROFILE_KERNEL should go into that condition as well. Thanks! Torsten