From: Borislav Petkov <bp@alien8.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Amy Wiles <amy.l.wiles@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86/rapl: Do not load in a guest
Date: Fri, 4 Dec 2015 11:56:17 +0100 [thread overview]
Message-ID: <20151204105617.GB21177@pd.tnic> (raw)
In-Reply-To: <56616DBF.8040900@redhat.com>
On Fri, Dec 04, 2015 at 11:41:03AM +0100, Paolo Bonzini wrote:
> No, please don't. Why do you need a wrmsr instead of a rdmsr? If
> there's no RAPL domains, the device doesn't load. On hypervisors,
> reading random MSRs is generally safe.
Well, we could not do anything, sure, that's an option too. It would
only be the annoying error message. Which is
pr_err("no valid rapl domains found in package %d\n", rp->id);
I guess we can tone that down as apparently it is not an error to
not have valid rapl domains anymore. Maybe kill it altogether:
rapl_detect_topology() will propagate the error and the driver won't
load...
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2015-12-04 10:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 18:27 [PATCH] x86/rapl: Do not load in a guest Borislav Petkov
2015-12-03 18:38 ` Jacob Pan
2015-12-03 18:42 ` Borislav Petkov
2015-12-03 18:59 ` Jacob Pan
2015-12-03 23:32 ` Rafael J. Wysocki
2015-12-03 23:25 ` Borislav Petkov
2015-12-04 1:00 ` Rafael J. Wysocki
2015-12-04 7:42 ` Ingo Molnar
2015-12-04 8:22 ` Peter Zijlstra
2015-12-04 8:28 ` Ingo Molnar
2015-12-04 10:19 ` Borislav Petkov
2015-12-04 10:41 ` Paolo Bonzini
2015-12-04 10:56 ` Borislav Petkov [this message]
2015-12-04 11:53 ` Ingo Molnar
2015-12-04 17:46 ` Jacob Pan
2015-12-04 17:52 ` Paolo Bonzini
2015-12-04 18:04 ` Borislav Petkov
2015-12-04 18:16 ` Jacob Pan
2015-12-04 18:28 ` Borislav Petkov
2015-12-04 18:37 ` Jacob Pan
2015-12-04 19:41 ` Borislav Petkov
2015-12-04 17:51 ` Jacob Pan
2015-12-04 22:14 ` Peter Zijlstra
2015-12-04 22:39 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204105617.GB21177@pd.tnic \
--to=bp@alien8.de \
--cc=acme@kernel.org \
--cc=amy.l.wiles@intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.