From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Dave Gordon" <david.s.gordon@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Takashi Iwai" <tiwai@suse.de>,
intel-gfx@lists.freedesktop.org
Subject: Re: Possible i915 regression with 4.4-rc
Date: Fri, 4 Dec 2015 12:16:40 +0000 [thread overview]
Message-ID: <20151204121640.GL27216@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20151204120659.GK27216@nuc-i3427.alporthouse.com>
On Fri, Dec 04, 2015 at 12:06:59PM +0000, Chris Wilson wrote:
> > Could also be down to certain objects getting their contents
> > discarded when evicted (due to not being marked dirty), for which I
> > posted a fix "Always mark GEM objects as dirty when written by the
> > CPU" a few days ago?
>
> Grasping at straws?
On reflection, rather than the object->dirty patch, you want
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem
_gtt.c
index 1f7e6b9df45d..033df035a066 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -346,6 +346,7 @@ static void cleanup_page_dma(struct drm_device *dev, struct
i915_page_dma *p)
static void *kmap_page_dma(struct i915_page_dma *p)
{
+ set_page_dirty(p->page);
return kmap_atomic(p->page);
}
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-04 12:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 20:00 Possible i915 regression with 4.4-rc Takashi Iwai
2015-12-03 20:33 ` Ville Syrjälä
2015-12-03 21:08 ` Takashi Iwai
2015-12-03 21:25 ` Ville Syrjälä
2015-12-03 21:35 ` Chris Wilson
2015-12-04 8:44 ` Jani Nikula
2015-12-04 15:57 ` Daniel Vetter
2015-12-04 12:00 ` Dave Gordon
2015-12-04 12:06 ` Chris Wilson
2015-12-04 12:16 ` Chris Wilson [this message]
2015-12-04 12:45 ` Chris Wilson
2015-12-03 21:38 ` Lukas Wunner
2015-12-08 7:03 ` Takashi Iwai
2015-12-04 8:49 ` Jani Nikula
2015-12-04 9:40 ` Ville Syrjälä
2015-12-04 16:02 ` Daniel Vetter
2015-12-04 16:12 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204121640.GL27216@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tiwai@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.