From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753549AbbLDMz2 (ORCPT ); Fri, 4 Dec 2015 07:55:28 -0500 Received: from mail-lf0-f54.google.com ([209.85.215.54]:34486 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbbLDMz0 (ORCPT ); Fri, 4 Dec 2015 07:55:26 -0500 Date: Fri, 4 Dec 2015 13:55:21 +0100 From: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= To: Darren Hart Cc: Matthew Garrett , Pali =?utf-8?B?Um9ow6Fy?= , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski Subject: Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131 Message-ID: <20151204125521.GA13406@eudyptula.hq.kempniu.pl> References: <20151130211542.GE30553@malice.jf.intel.com> <1654e7bcde98f1cf89f698a1e359110c06c6fcd4.1448999372.git.kernel@kempniu.pl> <20151204011606.GI1800@malice.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151204011606.GI1800@malice.jf.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On some laptop models (e.g. Dell Vostro V131), pressing the Dell Instant > > Launch hotkey does not raise an i8042 interrupt - only WMI event 0xe025 > > is generated. As there seems to be no ACPI method or SMI call to > > determine without possible side effects whether a given machine is > > capable of simulating a keypress when this hotkey is pressed, DMI > > matching is used to whitelist the models for which an input event should > > be generated when WMI event 0xe025 is received. > > > > Signed-off-by: Michał Kępień > > --- > > Changes from v1: > > > > - Use DMI matching instead of a module parameter > > - Change flag name to improve readability > > > > Darren, I am aware this patch conflicts with Andy's WMI rework series > > posted yesterday, so please just let me know if you want me to rebase. > > Thanks for the heads' up. Andy's series is longer and likely going to need more > review from more people, so I don't necessarily want to hold this one up on it - > unless it makes sense to include it in that series so they can evolve together. > I'll leave that to you and Andy to decide. As merging my patch with Andy's work is just a matter of moving code around, not actually changing it, personally I don't feel this patch should be somehow linked to the WMI rework. Andy, please let me know if you disagree, I don't really have any strong feelings about this. -- Best regards, Michał Kępień