From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755314AbbLFD5k (ORCPT ); Sat, 5 Dec 2015 22:57:40 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:53196 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754250AbbLFDoF (ORCPT ); Sat, 5 Dec 2015 22:44:05 -0500 Message-Id: <20151206013134.345577008@telegraphics.com.au> User-Agent: quilt/0.50-1 Date: Sun, 06 Dec 2015 12:31:56 +1100 From: Finn Thain To: "James E.J. Bottomley" , Michael Schmitz , , , Subject: [PATCH v2 30/72] ncr5380: Add missing break after case MESSAGE_REJECT References: <20151206013126.995379403@telegraphics.com.au> Content-Disposition: inline; filename=ncr5380-missing-break Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org MESSAGE REJECT does not imply DISCONNECT: the target is about to enter MESSAGE IN or MESSAGE OUT phase. This bug fix comes from atari_NCR5380.c. Unfortunately it never made it into the original NCR5380.c core driver. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 1 + 1 file changed, 1 insertion(+) Index: linux/drivers/scsi/NCR5380.c =================================================================== --- linux.orig/drivers/scsi/NCR5380.c 2015-12-06 12:30:17.000000000 +1100 +++ linux/drivers/scsi/NCR5380.c 2015-12-06 12:30:18.000000000 +1100 @@ -1985,6 +1985,7 @@ static void NCR5380_information_transfer default: break; } + break; case DISCONNECT:{ /* Accept message by clearing ACK */ NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Subject: [PATCH v2 30/72] ncr5380: Add missing break after case MESSAGE_REJECT Date: Sun, 06 Dec 2015 12:31:56 +1100 Message-ID: <20151206013134.345577008@telegraphics.com.au> References: <20151206013126.995379403@telegraphics.com.au> Return-path: Content-Disposition: inline; filename=ncr5380-missing-break Sender: linux-kernel-owner@vger.kernel.org To: "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-m68k@vger.kernel.org MESSAGE REJECT does not imply DISCONNECT: the target is about to enter MESSAGE IN or MESSAGE OUT phase. This bug fix comes from atari_NCR5380.c. Unfortunately it never made it into the original NCR5380.c core driver. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 1 + 1 file changed, 1 insertion(+) Index: linux/drivers/scsi/NCR5380.c =================================================================== --- linux.orig/drivers/scsi/NCR5380.c 2015-12-06 12:30:17.000000000 +1100 +++ linux/drivers/scsi/NCR5380.c 2015-12-06 12:30:18.000000000 +1100 @@ -1985,6 +1985,7 @@ static void NCR5380_information_transfer default: break; } + break; case DISCONNECT:{ /* Accept message by clearing ACK */ NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE);