From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754981AbbLFDxq (ORCPT ); Sat, 5 Dec 2015 22:53:46 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:53131 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754375AbbLFDoL (ORCPT ); Sat, 5 Dec 2015 22:44:11 -0500 Message-Id: <20151206013138.395497393@telegraphics.com.au> User-Agent: quilt/0.50-1 Date: Sun, 06 Dec 2015 12:32:12 +1100 From: Finn Thain To: "James E.J. Bottomley" , Michael Schmitz , , , Subject: [PATCH v2 46/72] ncr5380: Fix NDEBUG_NO_DATAOUT flag References: <20151206013126.995379403@telegraphics.com.au> Content-Disposition: inline; filename=ncr5380-fix-NDEBUG_NO_DATAOUT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NDEBUG_NO_DATAOUT should not disable DATA IN phases too. Fix this. (This bug has long been fixed in atari_NCR5380.c.) Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/drivers/scsi/NCR5380.c =================================================================== --- linux.orig/drivers/scsi/NCR5380.c 2015-12-06 12:30:39.000000000 +1100 +++ linux/drivers/scsi/NCR5380.c 2015-12-06 12:30:41.000000000 +1100 @@ -1833,7 +1833,6 @@ static void NCR5380_information_transfer continue; } switch (phase) { - case PHASE_DATAIN: case PHASE_DATAOUT: #if (NDEBUG & NDEBUG_NO_DATAOUT) printk("scsi%d : NDEBUG_NO_DATAOUT set, attempted DATAOUT aborted\n", instance->host_no); @@ -1843,6 +1842,7 @@ static void NCR5380_information_transfer cmd->scsi_done(cmd); return; #endif + case PHASE_DATAIN: /* * If there is no room left in the current buffer in the * scatter-gather list, move onto the next one. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Subject: [PATCH v2 46/72] ncr5380: Fix NDEBUG_NO_DATAOUT flag Date: Sun, 06 Dec 2015 12:32:12 +1100 Message-ID: <20151206013138.395497393@telegraphics.com.au> References: <20151206013126.995379403@telegraphics.com.au> Return-path: Content-Disposition: inline; filename=ncr5380-fix-NDEBUG_NO_DATAOUT Sender: linux-kernel-owner@vger.kernel.org To: "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-m68k@vger.kernel.org NDEBUG_NO_DATAOUT should not disable DATA IN phases too. Fix this. (This bug has long been fixed in atari_NCR5380.c.) Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/drivers/scsi/NCR5380.c =================================================================== --- linux.orig/drivers/scsi/NCR5380.c 2015-12-06 12:30:39.000000000 +1100 +++ linux/drivers/scsi/NCR5380.c 2015-12-06 12:30:41.000000000 +1100 @@ -1833,7 +1833,6 @@ static void NCR5380_information_transfer continue; } switch (phase) { - case PHASE_DATAIN: case PHASE_DATAOUT: #if (NDEBUG & NDEBUG_NO_DATAOUT) printk("scsi%d : NDEBUG_NO_DATAOUT set, attempted DATAOUT aborted\n", instance->host_no); @@ -1843,6 +1842,7 @@ static void NCR5380_information_transfer cmd->scsi_done(cmd); return; #endif + case PHASE_DATAIN: /* * If there is no room left in the current buffer in the * scatter-gather list, move onto the next one.