Re: [Qemu-devel] [PATCH v5 06/11] dump-guest-memory: disable dump when in INMIGRATE state

From: Peter Xu <peterx@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com,
	qemu-devel@nongnu.org, pbonzini@redhat.com,
	lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 06/11] dump-guest-memory: disable dump when in INMIGRATE state
Date: Mon, 7 Dec 2015 15:01:30 +0800	[thread overview]
Message-ID: <20151207070130.GB2776@pxdev.xzpeter.org> (raw)
In-Reply-To: <20151207061411.GC32154@ad.usersys.redhat.com>

On Mon, Dec 07, 2015 at 02:14:11PM +0800, Fam Zheng wrote:
> On Mon, 12/07 13:56, Peter Xu wrote:
> > +    if (runstate_check(RUN_STATE_INMIGRATE)) {
> > +        error_setg(errp, "Dump not allowed during incoming migration.");
> > +        return;
> > +    }
> > +
> 
> Detached dump when "inmigrate" is disabled, that's OK.  But what about sync
> dump? It used to be possible, but now is disabled. Just asking to make sure
> this is the intention rather than oversight.

That's my intention here. This should be an idea from one of Paolo's
review comment (forgot which one) and I hope I did not miss
anything. I took this since I failed to find a use case that user
might dump guest memory during incoming migration.

Thanks.
Peter

> 
> Fam