From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35262)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a5ppa-0004nN-10
	for qemu-devel@nongnu.org; Mon, 07 Dec 2015 02:03:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a5ppV-0004BU-1r
	for qemu-devel@nongnu.org; Mon, 07 Dec 2015 02:03:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43434)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a5ppU-0004B4-ST
	for qemu-devel@nongnu.org; Mon, 07 Dec 2015 02:03:24 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (Postfix) with ESMTPS id 7FE23C0B7A0B
	for <qemu-devel@nongnu.org>; Mon,  7 Dec 2015 07:03:24 +0000 (UTC)
Date: Mon, 7 Dec 2015 15:03:09 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20151207070309.GC2776@pxdev.xzpeter.org>
References: <1449467796-15856-1-git-send-email-peterx@redhat.com>
	<1449467796-15856-11-git-send-email-peterx@redhat.com>
	<20151207062144.GD32154@ad.usersys.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20151207062144.GD32154@ad.usersys.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 10/11] Dump: add qmp command "query-dump"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com

On Mon, Dec 07, 2015 at 02:21:44PM +0800, Fam Zheng wrote:
> On Mon, 12/07 13:56, Peter Xu wrote:
> >      /* send DUMP_COMPLETED message (unconditionally) */
> > -    qapi_event_send_dump_completed(!!local_err, (local_err ? \
> > +    result = qmp_query_dump(NULL);
> > +    /* should never fails */
> 
> s/fails/fail/

Got.

> 
> > diff --git a/qmp-commands.hx b/qmp-commands.hx
> > index 7b6f915..eb5bfe2 100644
> > --- a/qmp-commands.hx
> > +++ b/qmp-commands.hx
> > @@ -858,8 +858,9 @@ Arguments:
> >  - "protocol": destination file(started with "file:") or destination file
> >                descriptor (started with "fd:") (json-string)
> >  - "detach": if specified, command will return immediately rather than waiting
> > -            for the dump completion. A DUMP_COMPLETED event will occur at
> > -            the end. (json-bool)
> > +            for the dump completion. The user can track progress using
> > +            "query-dump" A DUMP_COMPLETED event will occur at the
> 
> Missing "." before "A DUMP_COMPLETED"?

Possibly... Changing both. Thanks!

Peter

> 
> > +            end. (json-bool)