From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 2/3] drm/atomic: Add __drm_atomic_helper_connector_reset. Date: Mon, 7 Dec 2015 10:58:21 +0100 Message-ID: <20151207095821.GA12387@ulmo> References: <20151124105101.GF6149@ulmo> <1448372134-26367-1-git-send-email-maarten.lankhorst@linux.intel.com> <1448372134-26367-2-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0640497645==" Return-path: In-Reply-To: <1448372134-26367-2-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0640497645== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h31gzZEtNLTqOjlF" Content-Disposition: inline --h31gzZEtNLTqOjlF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 24, 2015 at 02:35:33PM +0100, Maarten Lankhorst wrote: > This is useful for drivers that subclass connector_state, like tegra. >=20 > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/drm_atomic_helper.c | 30 ++++++++++++++++++++++++++---- > include/drm/drm_atomic_helper.h | 2 ++ > 2 files changed, 28 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_at= omic_helper.c > index cee31d43cd1c..5d23f818faec 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -2359,6 +2359,28 @@ void drm_atomic_helper_plane_destroy_state(struct = drm_plane *plane, > EXPORT_SYMBOL(drm_atomic_helper_plane_destroy_state); > =20 > /** > + * __drm_atomic_helper_connector_reset - default ->reset hook for connec= tors That's misleading because you can't use this as a ->reset() hook as-is. Maybe something like this would be better as a synopsis: __drm_atomic_helper_connector_reset - reset connector state Then the description below gives the details about what it does and when to use it, which looks fine to me. > + * @connector: drm connector > + * @conn_state: connector state to assign > + * > + * Initializes conn_state and assigns it to connector->state, usually > + * required at when initializing the drivers or when called from the s/required at/required/ Thierry --h31gzZEtNLTqOjlF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWZVg6AAoJEN0jrNd/PrOhWvgQAKRv2VDL4tzqqeJ7ZwVpUrKB S8Esv0aclPRYajwuA7BcCD+Zq/Rv5RDt3F+1oy/59wzdy9qEKPpUu1+KzsdtEVKs J4lC5v2l3bV8Z5djDsbxZK7Y4cB7OIKr7Vr/Y1Nlkv1jmj41KfGP6BnR7WNW6YLM U/mXalAP9YgdN1PQHXmKRhUccOhSUIqYRQdg+szzSatlaVhxIXD75CM9Si4VED3A C4TdbqCsTrz7tMqjGiflp57Xd2Vs/9S8CTRdD5NqenWehyL4OSlOD62Zw6Kl8Sse 6QGtcy8KpEbU2BA10IT6P8rMSsJo71EA7u8xR6Mug13dSt3DDzJraamKWbRLp30G iYJsEyjdcGgpzboMaUty2/KKDCkpf3m6u8ecBceqXYkSe5yfohAFb88CAl46y2bj Lj8Fdh4bg5UUg4GIYK2XvbuFQgcz8rgdZJvbivs5gwjqeh5Lu1kNLy81YKN2qdSU WDD3LkejJNPy/6xqGPCgYGbw5vFQAnriiJD6ZljSh2kz+e5dL17eI78QAcSZ5er1 gSxaXLoPFSv/KhQMrfqYlatS4zC8IEhH2fvlEPidRNypgRm47zp4uiY0q1JaENXr 68kIyw7WNTD4Z71UJgs1yBro+cQe0QjOd7koBvP0+Ct7+me1vRrZen25OapszLhW WSF64DHE/kXCOf/mr19i =Dre1 -----END PGP SIGNATURE----- --h31gzZEtNLTqOjlF-- --===============0640497645== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============0640497645==--