From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 3/3] drm/tegra: Use __drm_atomic_helper_reset_connector for subclassing connector state. Date: Mon, 7 Dec 2015 11:02:25 +0100 Message-ID: <20151207100225.GC12387@ulmo> References: <20151124105101.GF6149@ulmo> <1448372134-26367-1-git-send-email-maarten.lankhorst@linux.intel.com> <1448372134-26367-3-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0252089861==" Return-path: In-Reply-To: <1448372134-26367-3-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0252089861== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uXxzq0nDebZQVNAZ" Content-Disposition: inline --uXxzq0nDebZQVNAZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 24, 2015 at 02:35:34PM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/tegra/dsi.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c > index f0a138ef68ce..33ad50487f2e 100644 > --- a/drivers/gpu/drm/tegra/dsi.c > +++ b/drivers/gpu/drm/tegra/dsi.c > @@ -745,14 +745,11 @@ static void tegra_dsi_soft_reset(struct tegra_dsi *= dsi) > =20 > static void tegra_dsi_connector_reset(struct drm_connector *connector) > { > - struct tegra_dsi_state *state; > + struct tegra_dsi_state *state =3D > + kzalloc(sizeof(*state), GFP_KERNEL); I think this could use a check just for safety. It's unlikely to ever happen, but just in case, better allow to fail gracefully than crash. Thierry --uXxzq0nDebZQVNAZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWZVkxAAoJEN0jrNd/PrOhryMP/0Kl0TJOXlCLKSOX9kGyQC4X nnpuamoDDFJh5qiiBo6dabq+1TQjZPN6Nqy4GiR5eubQG9kvkf4phEmzlQK1ZK3g JTOTkvHwHkQMBRXWnVDSw2HLrruB7y5C6UctdNnMMUEcLKCZlRvSfvHl1oW/hUho QtTn5jo95ZLwvrSg/VWq44iFWOOdbR3D1rEndFx3ZIx+/o166lvMkM7oR3ic2N/x vcrW61YgwH3hw2AJIx5Y6+eMCQMp+W18IxWlc3LWMjtG5oqqG8NMgQeEBLsAu11U yLuf5SQYqLyQ1qq1GQSvyfzrlaoaHBJD9IXl55+eFUd4QtNEw8Mghx8Xm6grhjUT 8H49DxezCtX/YtZj03ZyXAjMR7ng2tBmUjOOfIcuberJiHQSZ2Mzgi7tlQ1QuJXn dR75Vr3fmHCbGukSudGMBIzveAfZaaaAeHpeWgKWfg31NcMRTjAqSk38x66AL2EM F63FJHTkQMTh96RtEeRbLy6g/bnKlpJfZrOPld5S8dDCLaWmjCiaK/2cHC74w6dM e7/gia/NfJPC/iie6LX4LnwuorCM8mvymiVa/u1D80hXD+LCrdHuee8cdbzDGdk0 uxZbubin7Q07wfMUfXOqN/BH0bI9W4vco+RaIMOy0C1zMZLze8CVkbJRwb/dKI+Z lBarPrKm15d6Os1OgTk5 =WxTa -----END PGP SIGNATURE----- --uXxzq0nDebZQVNAZ-- --===============0252089861== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============0252089861==--