From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 04/28] drm: Make helper vtable pointers type-safe Date: Mon, 7 Dec 2015 12:01:55 +0100 Message-ID: <20151207110155.GG13177@ulmo> References: <1449218769-16577-1-git-send-email-daniel.vetter@ffwll.ch> <1449218769-16577-5-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1191895556==" Return-path: In-Reply-To: <1449218769-16577-5-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============1191895556== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5UGlQXeG3ziZS81+" Content-Disposition: inline --5UGlQXeG3ziZS81+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 04, 2015 at 09:45:45AM +0100, Daniel Vetter wrote: > Originally the idea behind void* was to allow different sets of > helpers. But now we have that (with probe, plane, crtc and atomic > helpers) and we still just use the same set of vtables. That's the > only way to make the individual helpers modular and allow drivers to > pick&choose and transition between them. So this flexibility isn't > really needed. Also we have lots of non-vtable data meanwhile in core > structures too, this is not the first one at all. >=20 > Given that the void * is only trouble since gcc can't warn you if you > mix them up. Let's fix that and make them typesafe. >=20 > Signed-off-by: Daniel Vetter > --- > include/drm/drm_crtc.h | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) Very good: Reviewed-by: Thierry Reding --5UGlQXeG3ziZS81+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWZWcjAAoJEN0jrNd/PrOhaJcP/RQFsa41YF6X/6s+qy2xYIrx Qh9N1wbVPWgsdVJofNCEvLlRIsoscNrfXF9PO//Pxoak2mIhM2FX2IccLDisYV7e znq0Z9dD7MeU5pGv6FgZYFJH9cMpeejdwzTs73YwjBlEOr9kVgvQQAHEO0G7jzit hOSzqkNBf2I/k/GnmbxF3EStyGwUB0bqKylhmExHPHgQDXDP60mpNKpzslqOIScS uDArn/BIst1rsvzYRiscv7BppVR5Qsg+PsR2DFnxGgQGb5sSYByIjWPp1Lhf1D/c VFVJ6TZvisEh2XcLm2hJXJypx/cfBQOY7uNsbvmh0+0wMyQMSUpuksUF60kTKoN4 4abc1G2qlyHtJcnevp1xNqpaHYAYQ/Pu1OJYCtdvl0Yi5vRpYWAQHECRaPqfbzYb yYCtbrCEQWoi17syrFXAcKAavQBUJokQqE8MEMzFpO4PKO7Lou9bHSgjO2FquVFd 1/AeTuN8GoVV2yO1pnFG5/fX6ohI+mwc/JUWRPDR2512My2tf+lwxg0YCnPJhXeM i3gKXurax5auHquo71rDYf9OENiQgf/qDAn4giLpzqMKVfwZlO9X9N9FRhh8C97H wbkR0lRJf+BQFHbnFfvNPAvT7byUAOdkBixLBa2UrMwWReanUu9JKkGlaP1oz9tC hGz+q7VvIEerPQR98kzO =xa18 -----END PGP SIGNATURE----- --5UGlQXeG3ziZS81+-- --===============1191895556== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1191895556==--