From: Mel Gorman <mgorman@techsingularity.net>
To: Michal Hocko <mhocko@kernel.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Will Deacon <will.deacon@arm.com>,
"Huang, Ying" <ying.huang@linux.intel.com>,
virtualization@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] virtio: Do not drop __GFP_HIGH in alloc_indirect
Date: Mon, 7 Dec 2015 11:29:09 +0000 [thread overview]
Message-ID: <20151207112909.GH2015@techsingularity.net> (raw)
In-Reply-To: <1448980369-27130-1-git-send-email-mhocko@kernel.org>
On Tue, Dec 01, 2015 at 03:32:49PM +0100, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> b92b1b89a33c ("virtio: force vring descriptors to be allocated from
> lowmem") tried to exclude highmem pages for descriptors so it cleared
> __GFP_HIGHMEM from a given gfp mask. The patch also cleared __GFP_HIGH
> which doesn't make much sense for this fix because __GFP_HIGH only
> controls access to memory reserves and it doesn't have any influence
> on the zone selection. Some of the call paths use GFP_ATOMIC and
> dropping __GFP_HIGH will reduce their changes for success because the
> lack of access to memory reserves.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: Mel Gorman <mgorman@techsingularity.net>
It also has been tested by Ying Huang and found to have fixed a page
allocation failure problem in 4.4-rc3 in the Intel 0-day testing
infrastructure.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2015-12-07 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 14:32 [PATCH] virtio: Do not drop __GFP_HIGH in alloc_indirect Michal Hocko
2015-12-01 16:17 ` Will Deacon
2015-12-01 16:17 ` Will Deacon
2015-12-07 11:29 ` Mel Gorman [this message]
2015-12-07 11:29 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2015-12-01 14:32 Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207112909.GH2015@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=ying.huang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.